Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling +20 users/groups on batch endpoint payload #3759

Merged

Conversation

migldasilva
Copy link
Contributor

@migldasilva migldasilva commented Oct 18, 2023

Enabling +20 users/groups on batch endpoint payload

What is being addressed

An error is raised when creating an Airlock Import request, if the given App Registration has more than 20 users/groups assigned to it. As described in this bug report.

How is this addressed

  • Changing Core API's Python code, so that +20 users/groups are supported

Also changed rsa package, not sure why but tests couldn't find existing one.

@github-actions github-actions bot added the external PR from an external contributor label Oct 18, 2023
@marrobi
Copy link
Member

marrobi commented Oct 18, 2023

@migldasilva thanks, will review shortly. Can you increate the API version and add an entry to the changelog please :)

@github-actions
Copy link

github-actions bot commented Oct 18, 2023

Unit Test Results

577 tests   577 ✔️  14s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 35e01d2.

♻️ This comment has been updated with latest results.

@marrobi marrobi enabled auto-merge (squash) October 24, 2023 19:33
@marrobi
Copy link
Member

marrobi commented Oct 24, 2023

/test

@github-actions
Copy link

🤖 pr-bot 🤖

⚠️ When using /test on external PRs, the SHA of the checked commit must be specified

(in response to this comment from @marrobi)

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marrobi
Copy link
Member

marrobi commented Oct 24, 2023

/test 35e01d2

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/6632696259 (with refid a8ccbc3d)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 6d589c4 into microsoft:main Oct 24, 2023
10 checks passed
@migldasilva migldasilva deleted the migueldasilva/v0.14.0-no-retention-policy branch October 25, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external PR from an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants