JS auth policy lookup map (#2100)

CHANGELOG.md

@@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-## Unreleased
+## [0.17.1]
 
 ### Changed
 
@@ -641,6 +641,7 @@ Some discrepancies with the TR remain, and are being tracked under https://githu
 
 Initial pre-release
 
+[0.17.1]: https://github.com/microsoft/CCF/releases/tag/ccf-0.17.1
 [0.17.0]: https://github.com/microsoft/CCF/releases/tag/ccf-0.17.0
 [0.16.3]: https://github.com/microsoft/CCF/releases/tag/ccf-0.16.3
 [0.16.2]: https://github.com/microsoft/CCF/releases/tag/ccf-0.16.2

src/apps/js_generic/named_auth_policies.h

@@ -7,34 +7,49 @@
 
 namespace ccfapp
 {
-  static std::shared_ptr<ccf::AuthnPolicy> get_policy_by_name(
-    const std::string& name)
+  using NamedAuthPolicies =
+    std::unordered_map<std::string, std::shared_ptr<ccf::AuthnPolicy>>;
+
+  static NamedAuthPolicies& auth_policies_by_name()
   {
-    if (name == ccf::UserCertAuthnPolicy::SECURITY_SCHEME_NAME)
-    {
-      return ccf::user_cert_auth_policy;
-    }
-    if (name == ccf::UserSignatureAuthnPolicy::SECURITY_SCHEME_NAME)
-    {
-      return ccf::user_signature_auth_policy;
-    }
-    if (name == ccf::MemberCertAuthnPolicy::SECURITY_SCHEME_NAME)
-    {
-      return ccf::member_cert_auth_policy;
-    }
-    if (name == ccf::MemberSignatureAuthnPolicy::SECURITY_SCHEME_NAME)
-    {
-      return ccf::member_signature_auth_policy;
-    }
-    if (name == ccf::JwtAuthnPolicy::SECURITY_SCHEME_NAME)
+    static NamedAuthPolicies policies;
+    if (policies.empty())
     {
-      return ccf::jwt_auth_policy;
+      policies.emplace(
+        ccf::UserCertAuthnPolicy::SECURITY_SCHEME_NAME,
+        ccf::user_cert_auth_policy);
+      policies.emplace(
+        ccf::UserSignatureAuthnPolicy::SECURITY_SCHEME_NAME,
+        ccf::user_signature_auth_policy);
+
+      policies.emplace(
+        ccf::MemberCertAuthnPolicy::SECURITY_SCHEME_NAME,
+        ccf::member_cert_auth_policy);
+      policies.emplace(
+        ccf::MemberSignatureAuthnPolicy::SECURITY_SCHEME_NAME,
+        ccf::member_signature_auth_policy);
+
+      policies.emplace(
+        ccf::JwtAuthnPolicy::SECURITY_SCHEME_NAME, ccf::jwt_auth_policy);
+
+      policies.emplace(
+        ccf::EmptyAuthnPolicy::SECURITY_SCHEME_NAME, ccf::empty_auth_policy);
     }
-    if (name == ccf::EmptyAuthnPolicy::SECURITY_SCHEME_NAME)
+
+    return policies;
+  }
+
+  static std::shared_ptr<ccf::AuthnPolicy> get_policy_by_name(
+    const std::string& name)
+  {
+    auto& policies = auth_policies_by_name();
+    auto it = policies.find(name);
+    if (it == policies.end())
     {
-      return ccf::empty_auth_policy;
+      return nullptr;
     }
-    return nullptr;
+
+    return it->second;
   }
 
   template <typename T>