Remove member tables from whitelist #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
remove_member_table_puts@7069 aka 20200406.39 vs master ewma over 50 builds from 6261 to 7054 |
ashamis
approved these changes
Apr 6, 2020
achamayou
approved these changes
Apr 6, 2020
|
Thanks for fixing that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #806
Now that membership changes (addition or deletion of nodes) trigger issuing of new shares, it should not be possible for existing members to changes the members tables from a
raw_puts().We were still relying on this behaviour from one unit test and I've updated the proposal there accordingly.