-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run release enclaves without OE DEBUG flag #1083
Merged
Merged
Changes from 10 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8c7acb5
Compare enclave_type with "virtual", not "debug"
eddyashton 7c46cf1
Add a RELEASE EnclaveType in C++
eddyashton 52365d9
Plumb through 'release' option, as default
eddyashton 9929d61
Set -e debug for Debug builds
eddyashton de86679
Whoops quotes
eddyashton c989005
Merge branch 'master' into release_enclaves
achamayou f57c711
Merge branch 'master' into release_enclaves
achamayou c438409
Merge branch 'master' into release_enclaves
eddyashton 16188f9
Merge remote-tracking branch 'ea/release_enclaves' into release_enclaves
eddyashton baebccb
Merge branch 'master' into release_enclaves
achamayou 2e4f482
Remove Debug= lines
eddyashton 7f51065
Produce debuggable AND release libs, all the time
eddyashton fdc78b0
Mangle correct extension for debuggable libs
eddyashton 4369457
Copy correct file, remove temp dir
eddyashton 3975a00
cmake-format
eddyashton 36bfc44
Clarity
eddyashton 3474933
Merge branch 'release_enclaves' of github.com:eddyashton/CCF into rel…
eddyashton f66ab94
Add docs
eddyashton 9500e8c
Mention cchost arg
eddyashton 06f7fcc
Merge branch 'master' into release_enclaves
achamayou 9c7476d
De-editorialise
eddyashton fab8c9a
Merge branch 'release_enclaves' of github.com:eddyashton/CCF into rel…
eddyashton 630716f
Use enclave_type to build lib paths everywhere
eddyashton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a Debug/Debugging section that says "if you are going to be debugging, pass this flag and make sure the config has X, and be aware of the fact that your security guarantees are null and void", perhaps with a link to doc that exists about oegdb if any (or mention oegdb otherwise).