Set default enclave type by env var, not Python arg #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
overridable_enclave_type@7547 aka 20200422.15 vs master ewma over 50 builds from 7171 to 7546 |
jumaffre
approved these changes
Apr 22, 2020
olgavrou
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallout from #1083:
If you're in a
-CMAKE_BUILD_TYPE=Debugfolder, you may still want to run (and debug!) the virtual enclaves. But since we appended-e debugto the test argument, and your override option (env varTEST_ENCLAVE) is only used as the default for --enclave-type, this is not possible.This fixes that. Rather than appending to the command line, a
Debugor virtual-only build sets another env var, which is used as the default ofTEST_ENCLAVEis unset. Ifctestlet us append args at runtime, without a rebuild, this would look a lot less weird (our manual override could be an additional arg, rather than an env var).