Add experimental KV type wrapper

src/apps/logging/logging.cpp

@@ -283,17 +283,16 @@ namespace loggingapp
         .set_require_client_identity(false);
       install(Procs::LOG_RECORD_RAW_TEXT, log_record_text, Write);
 
-      nwt.signatures.set_global_hook([this, &notifier](
-                                       kv::Version version,
-                                       const ccf::Signatures::State& s,
-                                       const ccf::Signatures::Write& w) {
-        if (w.size() > 0)
-        {
-          nlohmann::json notify_j;
-          notify_j["commit"] = version;
-          notifier.notify(jsonrpc::pack(notify_j, jsonrpc::Pack::Text));
-        }
-      });
+      nwt.signatures.set_global_hook(
+        [this,
+         &notifier](kv::Version version, const ccf::Signatures::Write& w) {
+          if (w.size() > 0)
+          {
+            nlohmann::json notify_j;
+            notify_j["commit"] = version;
+            notifier.notify(jsonrpc::pack(notify_j, jsonrpc::Pack::Text));
+          }
+        });
     }
   };
 

src/consensus/pbft/pbft.h

@@ -573,7 +573,7 @@ namespace pbft
 
     void add_configuration(
       SeqNo seqno,
-      std::unordered_set<kv::NodeId> config,
+      const std::unordered_set<kv::NodeId>& config,
       const NodeConf& node_conf) override
     {
       if (node_conf.node_id == local_id)
@@ -594,6 +594,11 @@ namespace pbft
       nodes[node_conf.node_id] = 0;
     }
 
+    std::unordered_set<NodeId> get_latest_configuration() const override
+    {
+      throw std::logic_error("Unimplemented");
+    }
+
     void periodic(std::chrono::milliseconds elapsed) override
     {
       client_proxy->periodic(elapsed);

src/consensus/raft/raft.h

@@ -302,13 +302,23 @@ namespace raft
       return get_term_internal(idx);
     }
 
-    void add_configuration(Index idx, std::unordered_set<NodeId> conf)
+    void add_configuration(Index idx, const std::unordered_set<NodeId>& conf)
     {
       // This should only be called when the spin lock is held.
       configurations.push_back({idx, move(conf)});
       create_and_remove_node_state();
     }
 
+    std::unordered_set<NodeId> get_latest_configuration() const
+    {
+      if (configurations.empty())
+      {
+        return {};
+      }
+
+      return configurations.back().nodes;
+    }
+
     template <typename T>
     size_t write_to_ledger(const T& data)
     {

src/consensus/raft/raft_consensus.h

@@ -81,12 +81,17 @@ namespace raft
 
     void add_configuration(
       SeqNo seqno,
-      std::unordered_set<NodeId> conf,
+      const std::unordered_set<NodeId>& conf,
       const NodeConf& node_conf = {}) override
     {
       raft->add_configuration(seqno, conf);
     }
 
+    std::unordered_set<NodeId> get_latest_configuration() const override
+    {
+      return raft->get_latest_configuration();
+    }
+
     void periodic(std::chrono::milliseconds elapsed) override
     {
       raft->periodic(elapsed);