Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user_data to be set during new_user proposal #1488

Merged
merged 5 commits into from
Aug 7, 2020

Conversation

eddyashton
Copy link
Member

Previously users needed to be added by a "new_user" proposal, and then could have user data set by "set_user_data". This requires finding the assigned user ID (which is hard to do, and should be easier!), and enforces a period of time where the user has no user data.

This changes the expected data for "new_user"s from just a cert to a full UserInfo object, potentially including an initial user_data value.

@eddyashton eddyashton requested a review from a team as a code owner August 6, 2020 16:26
@ccf-bot
Copy link
Collaborator

ccf-bot commented Aug 6, 2020

initial_user_data@11594 aka 20200807.3 vs master ewma over 50 builds from 10983 to 11591
images

@eddyashton eddyashton merged commit 834fc52 into microsoft:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants