-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic member_data to simplify operator governance #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
member_data@13193 aka 20200928.14 vs master ewma over 50 builds from 12648 to 13190 |
jumaffre
reviewed
Sep 28, 2020
jumaffre
reviewed
Sep 28, 2020
jumaffre
approved these changes
Sep 28, 2020
achamayou
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1597.
This adds a
member_data
field for each member, in the same pattern asuser_data
, storing arbitrary JSON for the governance scripts to interpret how they wish.operator_gov.lua
is updated to use this, creating an object withis_operator = true
for operating members, rather than hardcoding them in the constitution.#1597 mentioned exposing the proposer's ID to the constitution, but I don't think this is actually necessary. We don't currently block proposals on any grounds, so we'd have to add that if we wanted to gate the creation of specific proposals to members/non-members. Instead we care about the operatoricity of each voter. In the case of proposals submitted by operators (which are freely submitted like any other members'), their single yes vote is sufficient to pass an 'operator proposal' (one of the constitution-defined calls), but this works purely by vote-iteration and doesn't need to consider the proposer separately.