-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to launch host processes #2461
Merged
achamayou
merged 21 commits into
microsoft:main
from
letmaik:letmaik/trigger-host-process-launch
May 28, 2021
Merged
Allow to launch host processes #2461
achamayou
merged 21 commits into
microsoft:main
from
letmaik:letmaik/trigger-host-process-launch
May 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
letmaik/trigger-host-process-launch@26231 aka 20210528.25 vs main ewma over 20 builds from 25716 to 26210 Click to see table
|
This looks good to me, as discussed it would be easier and preferable to use libuv to manage spawning and reaping processes. The execution is best triggered in the transaction itself rather than hooks, so long as it is idempotent there will be no functional ill-effects. |
…aik/CCF into letmaik/trigger-host-process-launch
achamayou
reviewed
May 28, 2021
achamayou
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to trigger host processes from an app endpoint. The app endpoint does not block on it.
What if the host process sends a response back to CCF (via HTTP) and the relevant app endpoint depends on the transaction that triggered the host process being finished/committed? Does it make sense to investigate an after-commit behaviour?
To expose it to JS I temporarily expose the node state as a second argument during
ccf
population. That's a work-around. Related to Makeccf
global injection in JS Context modular #2448