-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add session metrics endpoint #2596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might also be interesting to give stats on the number of requests that have been forwarded by this node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definitely deserves a CHANGELOG entry in my opinion.
That's a good idea, but could/should probably be done in the existing |
session_metrics@25654 aka 20210517.3 vs main ewma over 20 builds from 25297 to 25644 Click to see table
|
Resolves #2522.
I opted to put this under a new
/node/metrics
rather than/*/api/metrics
, because it is exclusively node-local./api/metrics
is as well, but due to an implementation quirk needs to exposed separately on each frontend (each counts only its own endpoints). Its an API minor version bump in any case (our first since #2589), and this way it only affects the/node
API.