js: Add ccf.crypto.verifySignature
#2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
letmaik/js-verify-signature@27736 aka 20210623.8 vs main ewma over 20 builds from 27398 to 27730 Click to see table
|
achamayou
reviewed
Jun 16, 2021
achamayou
reviewed
Jun 16, 2021
achamayou
reviewed
Jun 18, 2021
| @@ -251,6 +263,25 @@ export interface CCF { | |||
| */ | |||
| isValidX509CertChain(chain: string, trusted: string): boolean; | |||
|
|
|||
| crypto: { | |||
| /** | |||
| * Returns whether digital signature is valid. | |||
There was a problem hiding this comment.
It would be good to list the RSA key sizes and EC curve names this supports for clarity, either here or in the definitions of the SigningAlgorithm interfaces.
There was a problem hiding this comment.
There is no restriction on the RSA key sizes or EC curves. Anything that OE-OpenSSL supports will work. The only limitation is in the supported digest algorithms which is already a TypeScript type and self-documented. I'd like to extend that from SHA-256 eventually to SHA-384 but want to do it across the board, so including ccf.digest(), and currently CCF doesn't have native SHA-384 digest support.
I found https://github.com/openenclave/openenclave/blob/master/docs/OpenSSLSupport.md but it's not that useful.
|
If this PR is ok I'd like to get it merged and if possible kick off a dev release to consume it together with the new bytecode cache feature. |
letmaik
changed the title
ccf.verifySignatureccf.crypto.verifySignature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loosely modeled after https://developer.mozilla.org/en-US/docs/Web/API/SubtleCrypto/verify.