Remove HTTP signature for self RPCs #2885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 9, 2021 11:48
jumaffre
commented
Aug 9, 2021
CHANGELOG.md
Outdated
| @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
| ### Changed | |||
|
|
|||
| - CCF is now built with Clang 10. It is recommended that C++ applications upgrade to Clang 10 as well. | |||
| - Internal `/gov/jwt_keys/refresh` endpoint has been moved to `/node/jwt_keys/refresh`. | |||
There was a problem hiding this comment.
This endpoint isn't listed in the OpenAPI spec yet it shows up in the metrics for a given frontend so I've listed it here just in case.
achamayou
reviewed
Aug 9, 2021
achamayou
approved these changes
Aug 9, 2021
…e/CCF into fix_node_signature_self_requests
|
fix_node_signature_self_requests@30827 aka 20210813.3 vs main ewma over 20 builds from 30310 to 30824 Click to see table
|
added 2 commits
August 12, 2021 17:34
|
Force merging this PR as the Daily failure is unrelated (see #2896). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes' self RPCs (genesis and JWT refresh) were signed, but with the wrong
keyId. These signatures weren't actually verified so this PR removes the HTTP signature on those. Note that as discussed with @achamayou and @eddyashton, there is no apparent benefit in signing and storing these signatures currently (the primary node already emits signature transactions for blame), so we will hold off doing this for now.Also:
/gov/jwt_keys/refreshendpoint to/node/node/creategenesis endpoint that was made more permissive in Unify genesis and public recovery transaction execution #2876 with the node internal state, so that the endpoint can't be called once the service is open