Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renew node certificate proposal #2924

Merged
merged 148 commits into from
Oct 28, 2021

Conversation

jumaffre
Copy link
Contributor

@jumaffre jumaffre commented Aug 27, 2021

Part of #2893

WIP Now ready for review

This PR adds a new proposal action set_node_certificate_validity (and associated set_all_nodes_certificate_validity) to renew the certificate of a node.

The changes most concern:

  • The OpenSSL functions to manipulate time (see x509_time.h)
  • The certificate crypto API: caller can now specify a valid_from and valid_to string when creating a certificate
  • New CLI arguments to cchost (passed to the enclave, with one recorded in the service configuration table)
  • New JavaScript proposal actions
  • End-to-end testing. In particular, the infra remembers the validity period for a certificate so that the expected certificate validity period can be verified in the full_test_suite.

TODO:

  • Changelog
  • Docs
  • Remove hardcoded node certificate validity period and use host time on node creation instead
  • Add test for service certificate
  • Agree on strategy for initial validity period for joining nodes
  • Add validity_period_days parameter to transition_node_to_trusted proposal
  • Tighten end-to-end tests
  • Figure out strategy for adding fields to KV table and backwards compatibility
  • Local hook -> global hook to certificate refresh (follow-up PR, as requires extra refactoring)

Julien Maffre and others added 30 commits July 9, 2021 15:10
@jumaffre
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@jumaffre
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@jumaffre jumaffre merged commit e34f4bb into microsoft:main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants