-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renew node certificate proposal #2924
Merged
jumaffre
merged 148 commits into
microsoft:main
from
jumaffre:node_refresh_cert_proposal
Oct 28, 2021
Merged
Renew node certificate proposal #2924
jumaffre
merged 148 commits into
microsoft:main
from
jumaffre:node_refresh_cert_proposal
Oct 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumaffre
commented
Oct 19, 2021
jumaffre
commented
Oct 19, 2021
…into node_refresh_cert_proposal
jumaffre
commented
Oct 20, 2021
jumaffre
commented
Oct 20, 2021
…into node_refresh_cert_proposal
achamayou
approved these changes
Oct 27, 2021
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2893
WIPNow ready for reviewThis PR adds a new proposal action
set_node_certificate_validity
(and associatedset_all_nodes_certificate_validity
) to renew the certificate of a node.The changes most concern:
x509_time.h
)valid_from
andvalid_to
string when creating a certificatecchost
(passed to the enclave, with one recorded in the service configuration table)full_test_suite
.TODO:
validity_period_days
parameter totransition_node_to_trusted
proposal