-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include receipt evidence in snapshot #2998
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceipt_in_snapshot
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
achamayou
reviewed
Oct 4, 2021
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2958
Instead of having to verify the evidence of a snapshot in a ledger suffix, which complicated operations, the receipt of the evidence is now directory included in the snasphot file, making them self verifiable.
See inline comments for more details.
TODO:
ledger.py
andsnapshot_serialise.h
networkcert.pem
(follow-up PR). Also use new flag inread_ledger.py
.