Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More return code variants for some possible exceptions on Enclave() creation #3116

Merged
merged 17 commits into from
Oct 22, 2021
Merged

More return code variants for some possible exceptions on Enclave() creation #3116

merged 17 commits into from
Oct 22, 2021

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Oct 21, 2021 •
edited
Loading

This is to make it easier to debug environment-related startup issues.

@achamayou achamayou requested a review from a team as a code owner October 21, 2021 20:04
@achamayou achamayou added the 1.x-todo PRs which should be backported to 1.x label Oct 21, 2021
@jumaffre
Copy link
Contributor

Backporting this PR will need to backport #2532 too, which I (we?) assumed was already backported.

@achamayou
Copy link
Member Author

@jumaffre unless I'm missing something, that's an independent change? It's probably good to backport #2532 as well, but not necessary for this change to work as far as I can tell.

@ccf-bot
Copy link
Collaborator

ccf-bot commented Oct 22, 2021 •
edited
Loading

more_detailed_rc@35009 aka 20211022.24 vs main ewma over 20 builds from 34649 to 35003

Click to see table
build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem Historical query (/s)^ CHAMP put (/s)^ CHAMP get (/s)^
34649 20211018.11 6542.64 9.29342e+07 23886.9 1.92717e+07 4483.9 1.6126e+07 2731.23 1.32424e+07 2700.77 1.03588e+07 1821.67 8.2617e+06 8279.87 1.45505e+06 3.58669e+07
34670 20211019.1 6759.31 9.16235e+07 23687.7 1.95339e+07 4486.34 1.58639e+07 2763.74 1.0621e+07 2581.46 1.50774e+07 1812.4 8.2617e+06 8072.29 1.48394e+06 3.63759e+07
34675 20211019.3 6413.23 9.16235e+07 23950.4 1.90096e+07 4549.52 1.63882e+07 2792.32 1.4291e+07 2579.63 1.0621e+07 1802.07 8.52384e+06 7623.15 1.45175e+06 3.57417e+07
34725 20211019.17 6676.45 9.16235e+07 24143 1.90096e+07 4381.08 1.58639e+07 2806.06 1.27181e+07 2647.32 1.53396e+07 1837.93 8.2617e+06 8456.48 1.45815e+06 3.58663e+07
34756 20211019.23 6576.93 9.05749e+07 24045.3 1.84853e+07 4383.99 1.6126e+07 2778.02 1.14074e+07 2619.51 1.50774e+07 1838.62 8.52384e+06 8527.85 1.47901e+06 3.65056e+07
34771 20211020.1 6708.61 9.29342e+07 23856 1.84853e+07 4484.76 1.58639e+07 2771.45 1.03588e+07 2674.89 1.50774e+07 1844.59 1.03588e+07 8391.57 1.45227e+06 3.54939e+07
34776 20211020.3 6562.55 9.05749e+07 23698.3 1.87475e+07 4305.74 1.6126e+07 2763.18 1.40289e+07 2615.66 1.08831e+07 1812.46 8.52384e+06 8330.37 1.44408e+06 3.59298e+07
34792 20211020.8 6637.81 9.10992e+07 24543 1.9796e+07 4469.45 1.6126e+07 2624.63 1.48153e+07 2388.95 1.00967e+07 1772.6 8.52384e+06 8230.04 1.47825e+06 3.65708e+07
34833 20211020.20 6728.83 9.29342e+07 23737.6 1.87475e+07 4494.72 1.6126e+07 2707.47 9.83456e+06 2382.27 1.03588e+07 1807.88 8.52384e+06 8328.74 1.42816e+06 3.58663e+07
34863 20211021.2 6762.15 9.13613e+07 24352.9 2.03203e+07 4543.69 1.6126e+07 2726.01 1.0621e+07 2433.45 1.40289e+07 1805.26 8.52384e+06 7075.44 1.4663e+06 3.53707e+07
34870 20211021.5 6663.64 9.10992e+07 24379.2 1.76989e+07 4538.29 1.58639e+07 2716.82 1.2456e+07 2409.42 1.40289e+07 1811.3 8.52384e+06 7878.25 1.47443e+06 3.65708e+07
34882 20211021.8 6580.86 9.13613e+07 24443 1.7961e+07 4531.98 1.56017e+07 2641.4 1.03588e+07 2384.53 1.00967e+07 1797.21 8.52384e+06 8020.16 1.44032e+06 3.58042e+07
34894 20211021.10 6655.07 9.16235e+07 24244.1 1.7961e+07 4517.13 1.58639e+07 2741.63 1.00967e+07 2442.18 1.03588e+07 1829.51 8.52384e+06 7625.4 1.45703e+06 3.58669e+07
34899 20211021.11 6604.52 9.21478e+07 23714.7 1.82232e+07 4556.75 1.56017e+07 2699.3 9.83456e+06 2400.93 1.32424e+07 1809.16 8.52384e+06 8573.45 1.4498e+06 3.55556e+07
34901 20211021.12 6614.42 9.13613e+07 24279 1.90096e+07 4352.5 1.58639e+07 2604.99 1.03588e+07 2370.06 1.00967e+07 1811.4 8.2617e+06 7966.97 1.44103e+06 3.56794e+07
34909 20211021.13 6626.64 9.21478e+07 24376.4 1.76989e+07 4581.45 1.53396e+07 2656.79 1.32424e+07 2391.91 1.29803e+07 1837.36 8.52384e+06 8424.7 1.46201e+06 3.63121e+07
34910 20211021.14 6638.7 9.03128e+07 24054 1.82232e+07 4492.71 1.56017e+07 2675.69 1.0621e+07 2385.34 1.40289e+07 1811.96 7.99955e+06 8394.45 1.45693e+06 3.55556e+07
34932 20211022.2 6740.2 9.21478e+07 24350.6 1.7961e+07 4562.06 1.56017e+07 2721.85 1.00967e+07 2376.15 1.03588e+07 1810.07 8.52384e+06 8195.98 1.42896e+06 3.58669e+07
34972 20211022.14 6545.38 9.13613e+07 24492.2 1.7961e+07 4556.96 1.56017e+07 2724.6 1.0621e+07 2455.65 1.2456e+07 1827.89 8.52384e+06 7847.54 1.45206e+06 3.55556e+07
35003 20211022.23 6544.74 9.16235e+07 24300.1 1.7961e+07 4551.02 1.56017e+07 2709 1.03588e+07 2378.04 1.40289e+07 1821.85 8.52384e+06 7956.33 1.48372e+06 3.57411e+07

images

@achamayou achamayou merged commit e95639a into microsoft:main Oct 22, 2021
achamayou added a commit to achamayou/CCF that referenced this pull request Oct 22, 2021
@achamayou
Cherry-pick microsoft#3116
1b7f2aa
achamayou added a commit that referenced this pull request Oct 22, 2021
@achamayou
Cherry-pick #3116 (#3122)
53dac5c
@achamayou achamayou removed the 1.x-todo PRs which should be backported to 1.x label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jumaffre jumaffre jumaffre left review comments

@eddyashton eddyashton eddyashton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achamayou @jumaffre @ccf-bot @eddyashton