Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Python client code out of ccf package and back to infra #3386

Merged
merged 10 commits into from
Jan 12, 2022

Conversation

jumaffre
Copy link
Contributor

Fix #3372

Reason outlined in #3372:

Since CCF has been using standard client-server protocols (TLS, HTTP) for a while now, clients.py and other client helper functions can be moved back to tests/infra. The only remaining modules should be the ones that inspect the ledger or receipts.

The documentation has been updated accordingly (with a warning in the page that used to describe the ccf Python clients module).

@jumaffre jumaffre requested a review from a team January 11, 2022 15:10
@ghost
Copy link

ghost commented Jan 11, 2022

remove_clients_ccf_python@39836 aka 20220112.4 vs main ewma over 20 builds from 39465 to 39832

Click to see table

main

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
39465 20220105.23 6484.31 9.05749e+07 23326.9 1.66503e+07 5748.84 1.56017e+07 2649.77 1.2456e+07 1685.26 1.87568e+08 2354.44 1.11453e+07 1554.99 9.73907e+07 2071.04 1.11453e+07 12666.5 903351 1.41056e+06 9.32176e+06 3.65714e+07
39479 20220106.1 6037.81 9.00506e+07 22858.1 1.63882e+07 5780.57 1.56017e+07 2628.78 1.08831e+07 1674.53 1.87568e+08 2356.22 1.45532e+07 1534.36 9.76528e+07 1982.23 1.14074e+07 12216.9 908558 1.37007e+06 9.19615e+06 3.58669e+07
39591 20220109.3 6351.17 9.10992e+07 22869.8 1.63882e+07 5831.79 1.56017e+07 2587.6 1.37667e+07 1675.75 1.87568e+08 2259.97 1.50774e+07 1563.58 9.71285e+07 1983.46 1.21939e+07 10627.4 906510 1.36487e+06 9.1387e+06 3.58669e+07
39613 20220109.9 6339.29 8.97885e+07 23066 1.69124e+07 5739.9 1.56017e+07 2634.24 1.0621e+07 1679.41 1.89141e+08 2341.17 1.11453e+07 1556.91 9.76528e+07 2021.92 1.19317e+07 13186.2 931116 1.37995e+06 9.39441e+06 3.63759e+07
39619 20220110.2 6294.86 9.00506e+07 22200.2 1.63882e+07 5744.3 1.58639e+07 2510.36 1.2456e+07 1633.55 1.88355e+08 2177.01 1.40289e+07 1525.83 9.76528e+07 1972.14 1.16696e+07 13111.2 863947 1.34497e+06 9.09814e+06 3.51286e+07
39643 20220110.8 6183.49 8.97885e+07 22960.2 1.69124e+07 5855.31 1.6126e+07 2628.65 1.08831e+07 1676.04 1.87568e+08 2295.82 1.32424e+07 1549.83 9.73907e+07 2007.8 9.57242e+06 13110.5 910863 1.37624e+06 9.27108e+06 3.53103e+07
39677 20220110.18 6402.19 9.00506e+07 22711.6 1.76989e+07 5827.5 1.56017e+07 2614.99 1.0621e+07 1677.6 1.87568e+08 2393.4 1.08831e+07 1532.29 9.76528e+07 2012.52 9.57242e+06 13143.8 907996 1.41007e+06 9.26269e+06 3.56174e+07
39691 20220110.23 6180.17 9.08371e+07 22724 1.7961e+07 5808.02 1.56017e+07 2622.28 1.08831e+07 1666.14 1.87306e+08 2306.13 1.35046e+07 1531.02 9.73907e+07 2014.29 1.29803e+07 13130.2 908721 1.36196e+06 9.24184e+06 3.58669e+07
39701 20220110.27 6265.19 9.10992e+07 22865.9 1.58639e+07 5826.32 1.56017e+07 2647.55 1.27181e+07 1665.03 1.87306e+08 2314.75 1.48153e+07 1526.51 9.81771e+07 1970.95 1.21939e+07 13169.7 910047 1.36513e+06 9.26684e+06 3.58669e+07
39710 20220110.31 5816.43 9.13613e+07 22885.4 1.74367e+07 5801.97 1.58639e+07 2630.56 1.08831e+07 1668.06 1.87568e+08 2308.7 1.32424e+07 1524.27 9.76528e+07 1987.65 1.29803e+07 13129.1 865706 1.35584e+06 9.20863e+06 3.53103e+07
39719 20220110.34 6142.56 8.97885e+07 23460.7 1.69124e+07 5786.78 1.58639e+07 2573.11 1.37667e+07 1637.73 1.8783e+08 2311.82 1.08831e+07 1517.96 9.89635e+07 1954.97 9.83456e+06 11306.6 887419 1.35583e+06 9.24179e+06 3.58042e+07
39728 20220110.38 6250.27 9.05749e+07 22901.5 1.71746e+07 5811.64 1.53396e+07 2618.04 1.0621e+07 1637.04 1.9019e+08 2270.18 1.11453e+07 1520.15 9.79149e+07 1974.56 1.2456e+07 13096 910215 1.36233e+06 9.26274e+06 3.65714e+07
39734 20220111.2 6272.8 9.03128e+07 22352.6 1.66503e+07 5856.79 1.56017e+07 2592.15 1.29803e+07 1679.82 1.87568e+08 2309.62 1.11453e+07 1530.61 9.79149e+07 2023.21 1.16696e+07 12999.2 882187 1.3768e+06 9.34302e+06 3.58669e+07
39748 20220111.8 6294.54 8.95263e+07 22543.4 1.66503e+07 5856.5 1.56017e+07 2560.82 1.0621e+07 1658.51 1.89403e+08 2300.54 1.11453e+07 1521.57 9.76528e+07 2029.74 1.2456e+07 12798.3 894357 1.38687e+06 9.21273e+06 3.58669e+07
39760 20220111.13 6411.93 9.13613e+07 22169.9 1.71746e+07 5748.42 1.56017e+07 2593.45 1.37667e+07 1645.83 1.87568e+08 2291.42 1.08831e+07 1528.88 9.76528e+07 1980.52 9.57242e+06 12850.4 907837 1.37615e+06 9.24597e+06 3.55556e+07
39769 20220111.17 6150.83 9.00506e+07 22859.5 1.63882e+07 5742.42 1.56017e+07 2637.83 1.03588e+07 1659.95 1.87568e+08 2290.83 1.08831e+07 1529.52 9.73907e+07 1972.27 9.57242e+06 12902.1 919824 1.35539e+06 9.29637e+06 3.55556e+07
39781 20220111.22 6002.42 9.08371e+07 22980.5 1.63882e+07 5849.82 1.56017e+07 2626.72 1.2456e+07 1662.24 1.87306e+08 2308.12 1.35046e+07 1524.73 9.79149e+07 1978.39 1.19317e+07 13051 907632 1.37652e+06 9.23346e+06 3.59292e+07
39818 20220111.37 6225.16 9.13613e+07 23033.2 1.69124e+07 5841.82 1.56017e+07 2586.07 1.45532e+07 1678.59 1.87306e+08 2318.41 1.45532e+07 1521.06 9.73907e+07 1986.65 9.83456e+06 12701.5 899226 1.39518e+06 9.39014e+06 3.5128e+07
39829 20220112.2 6353.54 9.00506e+07 22932.4 1.69124e+07 5855.4 1.53396e+07 2642.31 1.2456e+07 1671.91 1.89403e+08 2260.36 1.40289e+07 1517.34 9.76528e+07 1986.27 9.57242e+06 12843.5 895763 1.35943e+06 9.22514e+06 3.58669e+07
39832 20220112.3 6326.87 9.05749e+07 22913.8 1.6126e+07 5795.46 1.56017e+07 2616.84 1.03588e+07 1673.85 1.89141e+08 2311.5 1.45532e+07 1526.96 9.92257e+07 1949.15 9.57242e+06 12821.3 876144 1.39547e+06 9.32596e+06 3.50679e+07

remove_clients_ccf_python

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
39777 20220111.20 6339.66 9.08371e+07 22816.2 1.71746e+07 5820.45 1.56017e+07 2547.27 1.0621e+07 1698.88 1.88879e+08 2147.63 1.45532e+07 1557.53 9.71285e+07 1982.69 1.35046e+07 12929.9 911066 1.382e+06 9.22518e+06 3.59298e+07
39785 20220111.23 6235.13 9.08371e+07 22947.8 1.66503e+07 5798.79 1.56017e+07 2574.63 1.03588e+07 1606.49 1.87568e+08 2224.09 1.45532e+07 1522.26 9.76528e+07 1980.05 1.32424e+07 12774.3 909166 1.3743e+06 9.27952e+06 3.58669e+07
39807 20220111.32 6122.96 9.10992e+07 22780 1.63882e+07 5579.7 1.56017e+07 2562.11 1.29803e+07 1657.29 1.87568e+08 2292.43 1.14074e+07 1526.11 9.76528e+07 1982.84 1.2456e+07 12830.7 915936 1.37247e+06 9.53001e+06 3.65721e+07
39824 20220111.39 6348.97 9.05749e+07 22963.3 1.69124e+07 5866.24 1.56017e+07 2625 1.27181e+07 1670.14 1.87568e+08 2322.17 1.08831e+07 1527.18 9.79149e+07 1980.73 1.35046e+07 12045.6 875360 1.3646e+06 9.326e+06 3.58042e+07
39836 20220112.4 6281.81 9.05749e+07 22742.8 1.74367e+07 5840.18 1.56017e+07 2631.3 1.27181e+07 1678.28 1.8783e+08 2309.77 1.32424e+07 1533.23 9.76528e+07 1976.93 1.19317e+07 12276.3 900017 1.38079e+06 9.21684e+06 3.58669e+07

images

js/ccf-app/package.json Outdated Show resolved Hide resolved
@achamayou
Copy link
Member

Apart from that, absolutely yes :)

@achamayou
Copy link
Member

@jumaffre can you add an entry to the changelog for this?

@achamayou achamayou enabled auto-merge (squash) January 12, 2022 09:32
@achamayou achamayou merged commit f302dda into microsoft:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all but ledger and receipt utility from ccf Python package
2 participants