Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move definition of RpcContext to public headers #3583

Merged
merged 9 commits into from
Feb 23, 2022

Conversation

eddyashton
Copy link
Member

One of the final major parts of #2428 - moving rpc_context.h to public headers. Since this is already an interface it's relatively simple, just involves moving some supporting types to public without pulling in too much supporting cruft.

@eddyashton eddyashton requested a review from a team as a code owner February 22, 2022 14:11
@ccf-bot
Copy link
Collaborator

ccf-bot commented Feb 22, 2022

public_rpc_context@42386 aka 20220223.21 vs main ewma over 20 builds from 42075 to 42374

Click to see table

main

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
42075 20220218.5 5645.07 9.05749e+07 19205.9 1.66503e+07 5589.19 1.56017e+07 2531.81 1.0621e+07 1635.21 1.61878e+08 2160.44 1.03588e+07 1467.45 9.87014e+07 1968.46 9.31027e+06 18034.8 922557 1.38107e+06 9.4074e+06 3.64413e+07
42089 20220218.11 5970.53 9.10992e+07 19748.5 1.63882e+07 5613.78 1.58639e+07 2526.78 1.08831e+07 1620.27 1.63975e+08 2114.89 9.83456e+06 1422.61 9.76528e+07 1907.5 9.31027e+06 18943.2 910096 1.38537e+06 9.25855e+06 3.57417e+07
42094 20220218.13 5968.92 9.00506e+07 20004.6 1.6126e+07 5685.72 1.56017e+07 2542.61 1.0621e+07 1659.39 1.61354e+08 2167.73 1.00967e+07 1477.41 9.92257e+07 1972.93 9.04813e+06 19940.9 910262 1.37829e+06 9.20445e+06 3.58036e+07
42121 20220218.24 5867.23 9.00506e+07 19773.3 1.66503e+07 5581.76 1.56017e+07 2542.89 1.03588e+07 1629.23 1.645e+08 2164.03 1.00967e+07 1479.84 9.84392e+07 1968.76 9.04813e+06 17943.9 893929 1.39395e+06 9.39445e+06 3.55556e+07
42144 20220218.32 5924.88 8.97885e+07 19749.4 1.69124e+07 5693.79 1.58639e+07 2523.42 1.0621e+07 1619.45 1.63975e+08 2165.48 1.14074e+07 1460.44 9.89635e+07 1938.67 9.57242e+06 19984.8 907952 1.38377e+06 9.21265e+06 3.58663e+07
42175 20220221.2 6075.56 9.13613e+07 19781 1.63882e+07 5494.48 1.56017e+07 2529.54 1.0621e+07 1624.12 1.61616e+08 2119.01 9.83456e+06 1475.48 9.84392e+07 1971.31 9.31027e+06 18140.9 902755 1.37902e+06 9.4334e+06 3.57417e+07
42191 20220221.7 6051.75 9.03128e+07 20063.8 1.69124e+07 5638.91 1.56017e+07 2540.21 1.08831e+07 1661.68 1.61354e+08 2182.64 9.83456e+06 1491.37 9.84392e+07 1943.5 9.57242e+06 17974.1 894982 1.38284e+06 9.27108e+06 3.56174e+07
42211 20220221.14 5930.94 9.13613e+07 19594.8 1.63882e+07 5652.28 1.56017e+07 2425.32 1.03588e+07 1612.61 1.63975e+08 2158.03 1.03588e+07 1473.15 9.84392e+07 2015 8.78598e+06 19769.4 879795 1.38154e+06 9.26269e+06 3.54939e+07
42229 20220221.20 5790.78 9.10992e+07 19795.7 1.6126e+07 5669.65 1.56017e+07 2402.08 1.0621e+07 1574.69 1.63713e+08 2159.76 1.32424e+07 1464.57 9.87014e+07 1926.65 9.57242e+06 17878.3 880893 1.34976e+06 9.19615e+06 3.5249e+07
42256 20220222.2 6017.97 9.18856e+07 19773.7 1.69124e+07 5594.56 1.56017e+07 2533.2 1.0621e+07 1650.07 1.64237e+08 2167.91 1.00967e+07 1474.53 9.87014e+07 1971.99 9.57242e+06 20985.9 898634 1.37634e+06 9.33876e+06 3.63766e+07
42274 20220222.10 5909.34 9.03128e+07 19948.7 1.69124e+07 5482.21 1.58639e+07 2540.55 1.0621e+07 1624.27 1.61616e+08 2168.01 9.83456e+06 1458.42 9.73907e+07 1812.84 1.0621e+07 20640.9 878213 1.37256e+06 9.29215e+06 3.54933e+07
42288 20220222.16 5744.88 9.05749e+07 19615.6 1.66503e+07 5621.54 1.58639e+07 2535.8 1.00967e+07 1610.04 1.64237e+08 2155.18 9.83456e+06 1393.29 9.87014e+07 1921.31 9.31027e+06 17777.5 913585 1.38218e+06 9.25432e+06 3.56794e+07
42293 20220222.18 5906.28 9.03128e+07 19469.5 1.69124e+07 5618.43 1.56017e+07 2552.77 1.00967e+07 1622.7 1.63975e+08 2200.94 9.31027e+06 1460.63 9.87014e+07 1971.63 9.31027e+06 19807.6 903670 1.39547e+06 9.39876e+06 3.58036e+07
42304 20220222.23 5948.35 9.05749e+07 19954.4 1.58639e+07 5648.99 1.56017e+07 2525.89 1.03588e+07 1637.15 1.63451e+08 2169.94 1.00967e+07 1463.39 9.84392e+07 1926.63 9.31027e+06 20133.1 904307 1.41523e+06 9.32176e+06 3.58042e+07
42313 20220222.27 5982.15 9.13613e+07 19778.6 1.69124e+07 5612.99 1.58639e+07 2527.02 1.03588e+07 1625.02 1.63451e+08 2159.41 1.03588e+07 1468.53 9.84392e+07 1913.15 1.16696e+07 18797 927151 1.37136e+06 9.3601e+06 3.56794e+07
42320 20220222.30 5920.73 9.13613e+07 19699.4 1.76989e+07 5608.83 1.56017e+07 2533.24 1.03588e+07 1624.96 1.63975e+08 2238.46 9.57242e+06 1428.2 9.84392e+07 1930.82 9.31027e+06 19850.5 911995 1.3819e+06 9.30901e+06 3.57411e+07
42335 20220222.37 6022.19 8.97885e+07 19906.9 1.58639e+07 5665.61 1.56017e+07 2591.34 1.03588e+07 1611.78 1.61354e+08 2110.27 1.00967e+07 1475.4 9.79149e+07 1970.6 9.57242e+06 17461.7 892447 1.38555e+06 9.48139e+06 3.64413e+07
42340 20220223.1 5927.85 8.97885e+07 20024.9 1.6126e+07 5653.94 1.56017e+07 2541.52 1.0621e+07 1662.2 1.61092e+08 2174.67 1.03588e+07 1494.42 9.87014e+07 2012.99 9.04813e+06 18159 894558 1.37459e+06 9.30909e+06 3.56174e+07
42353 20220223.7 5912.65 9.00506e+07 20216.4 1.66503e+07 5539.46 1.53396e+07 2536.54 1.0621e+07 1621.06 1.64237e+08 2155.5 1.03588e+07 1459.33 9.89635e+07 1966.69 9.57242e+06 22016.1 875171 1.37726e+06 9.28794e+06 3.59298e+07
42374 20220223.16 5895.23 9.00506e+07 20002.7 1.6126e+07 5581.94 1.56017e+07 2526.5 1.03588e+07 1623.18 1.63713e+08 2212.85 9.04813e+06 1474.99 9.87014e+07 1890.55 9.83456e+06 20607.7 881879 1.38237e+06 9.17555e+06 3.55549e+07

public_rpc_context

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
42303 20220222.22 6063.92 9.05749e+07 19964.3 1.69124e+07 5649.89 1.58639e+07 2517.15 1.08831e+07 1656.02 1.64237e+08 2163.07 1.00967e+07 1499 9.81771e+07 1973.63 9.04813e+06 18214.6 910581 1.41475e+06 9.47701e+06 3.53707e+07
42310 20220222.25 5821.64 9.08371e+07 19920.9 1.6126e+07 5606.71 1.56017e+07 2522.64 1.00967e+07 1628.96 1.63975e+08 2200.62 9.83456e+06 1473.59 9.92257e+07 1966.31 9.04813e+06 20133.5 910367 1.36877e+06 9.20847e+06 3.59292e+07
42371 20220223.14 5846.82 8.95263e+07 19821.6 1.6126e+07 5581.29 1.53396e+07 2539.5 1.03588e+07 1625.61 1.645e+08 2158.06 9.83456e+06 1460.93 9.87014e+07 1929.88 9.31027e+06 19324.9 907434 1.38696e+06 9.18382e+06 3.53103e+07
42386 20220223.21 6049.6 9.13613e+07 20019.1 1.58639e+07 5629.24 1.56017e+07 2550.32 1.0621e+07 1661.25 1.63451e+08 2159.44 1.2456e+07 1515.41 9.81771e+07 1976.33 9.04813e+06 20814.9 890353 1.37615e+06 9.2293e+06 3.63766e+07

images

@achamayou achamayou enabled auto-merge (squash) February 23, 2022 13:18
@achamayou achamayou merged commit 7948dcc into microsoft:main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants