-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resilient ledger recovery #3585
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto truncated_ledger_recovery
truncated_ledger_recovery@42438 aka 20220223.41 vs main ewma over 20 builds from 42121 to 42430 Click to see tablemain
truncated_ledger_recovery
|
…nto truncated_ledger_recovery
…nto truncated_ledger_recovery
achamayou
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3459
The recovery process is now resilient to ledger files having been partially written, as opposed to throwing early if an entry wasn't completely written to a ledger file (1.0) or marking a file as
.corrupted
and ignoring it entirely (main
currently). Instead, we recover as many entries as possible when this is the case and truncate the (uncommitted) ledger file if it wasn't recovered entirely.This is tested by a new end-to-end test in
recovery.py
which tests that the full recovery procedure can be done on a corrupted ledger (corrupted at the first tx, last tx and first signature) as well as a more precise unit test (seeledger.cpp
).TODO:
.corrupted
files in docs