Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI check that enforces public-only headers #3609

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

eddyashton
Copy link
Member

Now that #2428 is largely complete (only remaining violations are in sample apps, but the public headers themselves are pure-public), I want to ensure we don't accidentally regress.

@eddyashton eddyashton requested a review from a team as a code owner February 28, 2022 11:31
@ccf-bot
Copy link
Collaborator

ccf-bot commented Feb 28, 2022

enforce_public_headers@42619 aka 20220228.13 vs main ewma over 20 builds from 42340 to 42607

Click to see table

main

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
42340 20220223.1 5927.85 8.97885e+07 20024.9 1.6126e+07 5653.94 1.56017e+07 2541.52 1.0621e+07 1662.2 1.61092e+08 2174.67 1.03588e+07 1494.42 9.87014e+07 2012.99 9.04813e+06 18159 894558 1.37459e+06 9.30909e+06 3.56174e+07
42353 20220223.7 5912.65 9.00506e+07 20216.4 1.66503e+07 5539.46 1.53396e+07 2536.54 1.0621e+07 1621.06 1.64237e+08 2155.5 1.03588e+07 1459.33 9.89635e+07 1966.69 9.57242e+06 22016.1 875171 1.37726e+06 9.28794e+06 3.59298e+07
42374 20220223.16 5895.23 9.00506e+07 20002.7 1.6126e+07 5581.94 1.56017e+07 2526.5 1.03588e+07 1623.18 1.63713e+08 2212.85 9.04813e+06 1474.99 9.87014e+07 1890.55 9.83456e+06 20607.7 881879 1.38237e+06 9.17555e+06 3.55549e+07
42394 20220223.25 5909.78 9.03128e+07 19555.8 1.69124e+07 5629.48 1.6126e+07 2515.33 1.03588e+07 1619.53 1.63975e+08 2156.91 9.83456e+06 1465.29 9.87014e+07 1971.37 9.57242e+06 19961.8 904629 1.3721e+06 9.21273e+06 3.57411e+07
42411 20220223.32 5902.39 9.05749e+07 19851.4 1.58639e+07 5477.34 1.56017e+07 2478.09 1.27181e+07 1627.1 1.62402e+08 2154.39 9.57242e+06 1469.07 9.84392e+07 1960.46 9.57242e+06 20206.2 885617 1.37283e+06 9.21684e+06 3.56174e+07
42430 20220223.39 5837.66 9.03128e+07 18642.1 1.69124e+07 5588.65 1.58639e+07 2546.43 1.08831e+07 1620.83 1.63713e+08 2198.02 1.00967e+07 1482.28 9.84392e+07 2017.15 8.78598e+06 18115.8 901759 1.36733e+06 9.18382e+06 3.59923e+07
42443 20220223.43 6019.37 9.03128e+07 19536.1 1.66503e+07 6025.43 1.53396e+07 2541.15 1.0621e+07 1554.51 1.61878e+08 2157.41 1.00967e+07 1459.57 9.87014e+07 1958.65 9.04813e+06 18135.7 908278 1.36587e+06 9.26269e+06 3.58669e+07
42460 20220223.49 5767.13 9.03128e+07 19666.2 1.69124e+07 5585.23 1.56017e+07 2524.67 1.03588e+07 1595.59 1.63713e+08 2151.99 1.00967e+07 1452.35 9.66042e+07 1927.57 9.57242e+06 19999.7 906550 1.3732e+06 9.22103e+06 3.58036e+07
42469 20220224.1 6123.24 8.97885e+07 19806.3 1.6126e+07 5644.21 1.58639e+07 2543.96 1.08831e+07 1646.93 1.61878e+08 2157.68 1.00967e+07 1470.6 9.84392e+07 1966.06 9.57242e+06 23072 863474 1.32094e+06 9.0459e+06 3.50685e+07
42472 20220224.3 6148.23 9.10992e+07 19709.8 1.66503e+07 5570.8 1.58639e+07 2530.7 1.00967e+07 1643.84 1.63975e+08 2234.46 9.31027e+06 1479.9 9.87014e+07 1878.36 9.31027e+06 20064.6 905868 1.36806e+06 9.17148e+06 3.63121e+07
42482 20220224.7 5819.2 9.13613e+07 19070.4 1.76989e+07 5670.86 1.58639e+07 2548.75 1.00967e+07 1659.66 1.64237e+08 2170.71 9.83456e+06 1433.78 9.87014e+07 2018.62 8.78598e+06 19860.5 907433 1.37791e+06 9.32596e+06 3.58669e+07
42493 20220224.12 5875.37 8.97885e+07 19823.7 1.69124e+07 5585.1 1.58639e+07 2523.2 1.03588e+07 1624.08 1.63451e+08 2163.46 1.00967e+07 1462.51 9.84392e+07 1969.77 9.31027e+06 17923.5 891122 1.36495e+06 9.20024e+06 3.51884e+07
42504 20220224.17 5906.09 9.13613e+07 19792.8 1.71746e+07 5547.1 1.56017e+07 2543.23 1.03588e+07 1619.21 1.63975e+08 2165.34 1.03588e+07 1483.28 9.81771e+07 1975.63 9.04813e+06 18365.4 906546 1.38339e+06 9.20441e+06 3.58036e+07
42537 20220224.30 5655.68 8.9002e+07 20062.9 1.58639e+07 5631.94 1.53396e+07 2544.13 1.00967e+07 1619.93 1.62927e+08 2154.11 9.31027e+06 1454.47 9.76528e+07 1968.2 8.78598e+06 20149 910748 1.38024e+06 9.22107e+06 3.59298e+07
42547 20220225.1 6094.89 8.97885e+07 19937.4 1.63882e+07 5650.77 1.53396e+07 2523.98 1.00967e+07 1681.57 1.64237e+08 2162.24 9.31027e+06 1478.94 9.84392e+07 1961.62 8.78598e+06 21071.1 904509 1.38051e+06 9.30905e+06 3.58669e+07
42555 20220225.5 5985.94 8.97885e+07 19767.8 1.56017e+07 5665.28 1.53396e+07 2540.87 1.00967e+07 1631.76 1.63189e+08 2167.53 9.57242e+06 1477.28 9.81771e+07 1962.27 9.04813e+06 17933.6 921645 1.40244e+06 9.39445e+06 3.58042e+07
42582 20220226.1 6052.86 9.03128e+07 19533 1.58639e+07 5697.68 1.56017e+07 2525.56 1.00967e+07 1633.28 1.63713e+08 2236.09 9.57242e+06 1460.56 9.79149e+07 1926.83 8.78598e+06 19994.5 903356 1.37063e+06 9.30486e+06 3.58042e+07
42592 20220228.2 6066.9 8.97885e+07 20022.5 1.58639e+07 5654.4 1.53396e+07 2541.08 1.00967e+07 1620.94 1.63713e+08 2166.3 9.57242e+06 1436.21 9.79149e+07 1928.39 8.78598e+06 20273.8 886689 1.37865e+06 9.07797e+06 3.5128e+07
42594 20220228.3 6146.06 8.95263e+07 19896.7 1.63882e+07 5612.88 1.53396e+07 2535.45 1.00967e+07 1649.41 1.63975e+08 2204.4 9.57242e+06 1498.79 9.79149e+07 1961.82 8.52384e+06 22261.1 909691 1.40581e+06 9.39445e+06 3.65714e+07
42607 20220228.9 5860.86 8.9002e+07 20054.1 1.58639e+07 5659.33 1.56017e+07 2527.61 1.00967e+07 1618.31 1.63189e+08 2156.08 9.57242e+06 1475.95 9.81771e+07 1933.28 8.52384e+06 19974 926274 1.40321e+06 9.17555e+06 3.66369e+07

enforce_public_headers

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
42606 20220228.8 5959.02 9.03128e+07 19694.7 1.56017e+07 5658.64 1.53396e+07 2517.5 1.0621e+07 1593.44 1.62665e+08 2107.91 9.04813e+06 1433.69 9.81771e+07 1910.33 8.52384e+06 20095.5 909172 1.38706e+06 9.28798e+06 3.58042e+07
42619 20220228.13 5982.18 8.97885e+07 19890.7 1.63882e+07 5567.19 1.56017e+07 2514.69 1.00967e+07 1628.53 1.62927e+08 2173.46 9.57242e+06 1471.41 9.81771e+07 1917.54 8.78598e+06 20119.4 904189 1.37634e+06 9.24184e+06 3.58663e+07

images

@eddyashton eddyashton enabled auto-merge (squash) February 28, 2022 13:07
@eddyashton eddyashton merged commit c629ba6 into microsoft:main Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants