Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add free-form node_data field #3662

Merged
merged 11 commits into from
Mar 16, 2022
Merged

Add free-form node_data field #3662

merged 11 commits into from
Mar 16, 2022

Conversation

eddyashton
Copy link
Member

@eddyashton eddyashton commented Mar 15, 2022

Resolves #3644.

node_data can be passed at cchost startup time*, or via a set_node_data proposal. The objects returned in /network/nodes also include last_written, as a hint to when each node was added.

* The config argument is a top-level field named node_data_json_file. It's a path to a file for consistency with member_data. We could inline these now that we have a JSON config, rather than requiring them to be dumped to a separate file, but it's a more awkward change when migrating from 1.x to 2.x

TODO

  • CHANGELOG
  • Documented config schema

@eddyashton eddyashton requested a review from a team as a code owner March 15, 2022 16:16
@ccf-bot
Copy link
Collaborator

ccf-bot commented Mar 15, 2022

node_data@43249 aka 20220316.4 vs main ewma over 20 builds from 42964 to 43243

Click to see table

main

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
42964 20220309.23 6148.15 8.92642e+07 19972.9 1.58639e+07 5569.88 1.56017e+07 2529.01 1.19317e+07 1661.25 1.63451e+08 2159.3 9.31027e+06 1489.35 9.84392e+07 2016.97 9.04813e+06 20567.7 887766 1.38228e+06 9.24601e+06 3.64406e+07
42979 20220309.27 6063.95 8.95263e+07 19930 1.58639e+07 5589.12 1.53396e+07 2480.32 1.00967e+07 1647.32 1.63189e+08 2162.15 9.31027e+06 1488.03 9.81771e+07 1976.8 8.78598e+06 18163.2 902357 1.37421e+06 9.30478e+06 3.58669e+07
42985 20220310.1 6080.69 9.10992e+07 19991.2 1.69124e+07 5612.8 1.50774e+07 2534.28 1.00967e+07 1607.66 1.64237e+08 2166.65 9.04813e+06 1444.47 9.81771e+07 1967.59 8.78598e+06 18285.4 903432 1.39633e+06 9.22934e+06 3.58042e+07
43023 20220310.19 5999.14 9.00506e+07 19462 1.6126e+07 5529.8 1.56017e+07 2589.65 1.00967e+07 1616.47 1.63451e+08 2163.13 9.57242e+06 1477.33 9.76528e+07 1962.55 8.78598e+06 21037.5 897448 1.37448e+06 9.16737e+06 3.59292e+07
43035 20220310.24 6068.64 9.08371e+07 19893 1.58639e+07 5516.31 1.56017e+07 2630.1 1.00967e+07 1626.36 1.63189e+08 2154.51 9.31027e+06 1466.07 9.81771e+07 1970.31 8.78598e+06 19849.6 907835 1.38312e+06 9.32596e+06 3.53103e+07
43052 20220311.2 5913.12 8.97885e+07 18902.5 1.63882e+07 5567.19 1.56017e+07 2638.15 1.00967e+07 1650.91 1.63451e+08 2160.98 9.31027e+06 1470.53 9.81771e+07 1958.6 8.78598e+06 22533.5 886456 1.34558e+06 9.41601e+06 3.53103e+07
43062 20220311.6 6195.93 9.00506e+07 19652.7 1.58639e+07 5925.27 1.53396e+07 2540.16 1.00967e+07 1651.81 1.63975e+08 2164.38 9.04813e+06 1475.4 9.79149e+07 1967.26 8.78598e+06 18065.1 906751 1.37403e+06 9.27532e+06 3.59298e+07
43076 20220311.11 5937.91 9.00506e+07 19809.3 1.66503e+07 5619.77 1.53396e+07 2531.17 1.0621e+07 1629.53 1.63713e+08 2201.8 9.31027e+06 1470.15 9.81771e+07 1962.99 8.78598e+06 19228.9 888614 1.37449e+06 9.20032e+06 3.52496e+07
43102 20220311.21 5906.51 9.00506e+07 19291.7 1.66503e+07 5600.96 1.53396e+07 2543.24 1.00967e+07 1624.12 1.63975e+08 2162.19 9.04813e+06 1467.21 9.79149e+07 1970.97 8.78598e+06 20003.3 891010 1.40562e+06 9.22514e+06 3.48299e+07
43126 20220311.29 5904.07 8.97885e+07 19782.6 1.58639e+07 5521.4 1.53396e+07 2533.18 1.00967e+07 1618.01 1.62665e+08 2149.16 9.31027e+06 1469.13 9.81771e+07 2010.71 8.78598e+06 21007.7 913098 1.39309e+06 9.31324e+06 3.56788e+07
43133 20220312.2 5998.58 9.00506e+07 18908 1.58639e+07 5890 1.53396e+07 2649.18 1.00967e+07 1657.98 1.63189e+08 2114.31 9.04813e+06 1449.46 9.81771e+07 1973.26 8.78598e+06 19753.6 866432 1.37643e+06 9.16323e+06 3.50685e+07
43145 20220314.1 5873.31 8.9002e+07 18269.3 1.58639e+07 5489.47 1.56017e+07 2466.64 1.00967e+07 1614.79 1.62927e+08 2087.04 9.04813e+06 1426.38 9.76528e+07 1926.52 1.03588e+07 19658.1 907435 1.37366e+06 9.0941e+06 3.58036e+07
43154 20220314.6 6111.35 9.13613e+07 19349.8 1.58639e+07 5520.02 1.50774e+07 2644.96 1.00967e+07 1669.24 1.61092e+08 2111.53 9.04813e+06 1453.88 9.79149e+07 1968.5 8.52384e+06 19880.2 908519 1.37412e+06 9.28373e+06 3.56168e+07
43163 20220314.9 5968.52 8.97885e+07 19433 1.6126e+07 5634.3 1.56017e+07 2516.54 1.00967e+07 1635.23 1.63713e+08 2151.06 9.04813e+06 1434.34 9.84392e+07 1959.34 8.78598e+06 17102 906469 1.40465e+06 9.20441e+06 3.58042e+07
43184 20220315.2 6080.75 9.05749e+07 18974.1 1.69124e+07 5546.41 1.53396e+07 2533.56 1.00967e+07 1640.84 1.63451e+08 2114.06 1.19317e+07 1413.36 9.81771e+07 1967.91 8.52384e+06 20342.5 892834 1.36124e+06 9.2293e+06 3.58663e+07
43191 20220315.4 5989.8 8.95263e+07 19512.1 1.69124e+07 5657.37 1.53396e+07 2533.25 1.00967e+07 1676.28 1.63975e+08 2072.29 9.04813e+06 1422.39 9.79149e+07 1910.76 8.78598e+06 21591.8 894317 1.37182e+06 9.25436e+06 3.59298e+07
43199 20220315.7 5952.7 8.97885e+07 19490.9 1.56017e+07 5607.08 1.50774e+07 2647.92 1.00967e+07 1616.76 1.62927e+08 2104.52 9.04813e+06 1437.25 9.73907e+07 1974.21 8.52384e+06 17073.6 910541 1.36642e+06 9.39445e+06 3.56174e+07
43215 20220315.13 6022.15 8.95263e+07 19204 1.58639e+07 5538.54 1.53396e+07 2520.18 1.00967e+07 1614.49 1.62665e+08 2104.73 9.04813e+06 1437.65 9.81771e+07 1962.81 8.78598e+06 19456.5 897138 1.37837e+06 9.37295e+06 3.55556e+07
43221 20220315.15 5875.04 9.00506e+07 19288.9 1.6126e+07 5576.94 1.56017e+07 2634.85 1.00967e+07 1659.66 1.63975e+08 2101.09 9.04813e+06 1443.59 9.84392e+07 1919.68 8.78598e+06 18570.9 909939 1.38481e+06 9.25023e+06 3.58042e+07
43243 20220316.1 5936.24 8.92642e+07 19477.5 1.58639e+07 5557.28 1.58639e+07 2589.02 1.00967e+07 1635.28 1.63451e+08 2119.25 9.04813e+06 1442.27 9.81771e+07 1972.73 8.78598e+06 17549.9 910384 1.39757e+06 9.37729e+06 3.58669e+07

node_data

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
43229 20220315.18 6057.6 9.00506e+07 18708.3 1.6126e+07 5535.79 1.50774e+07 2649.63 1.00967e+07 1613.52 1.63975e+08 2147.83 9.04813e+06 1439.99 9.79149e+07 1969.76 8.78598e+06 18835.5 903272 1.39111e+06 9.22518e+06 3.59298e+07
43249 20220316.4 5982.59 8.9002e+07 19370 1.58639e+07 5579.29 1.53396e+07 2522.14 1.00967e+07 1629.43 1.63189e+08 2109.21 9.31027e+06 1436.79 9.79149e+07 1923.96 8.78598e+06 19606.7 910621 1.3676e+06 9.37291e+06 3.58042e+07

images

@achamayou
Copy link
Member

@eddyashton doxygen's not happy:

/__w/1/s/src/node/rpc/serialization.h:76: error: Found ';' while parsing initializer list! (doxygen could be confused by a macro call without semicolon) (warning treated as error, aborting now)

@achamayou achamayou merged commit 5e05584 into microsoft:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add last_written to each node in /node/network/nodes
4 participants