-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add free-form node_data
field
#3662
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
reviewed
Mar 15, 2022
achamayou
reviewed
Mar 15, 2022
node_data@43249 aka 20220316.4 vs main ewma over 20 builds from 42964 to 43243 Click to see tablemain
node_data
|
jumaffre
reviewed
Mar 15, 2022
jumaffre
reviewed
Mar 15, 2022
achamayou
approved these changes
Mar 16, 2022
@eddyashton doxygen's not happy:
|
achamayou
reviewed
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3644.
node_data
can be passed at cchost startup time*, or via aset_node_data
proposal. The objects returned in/network/nodes
also includelast_written
, as a hint to when each node was added.* The config argument is a top-level field named
node_data_json_file
. It's a path to a file for consistency withmember_data
. We could inline these now that we have a JSON config, rather than requiring them to be dumped to a separate file, but it's a more awkward change when migrating from 1.x to 2.xTODO