Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect unsafe status in /node/version #3942

Merged
merged 10 commits into from
Jun 21, 2022
Merged

Reflect unsafe status in /node/version #3942

merged 10 commits into from
Jun 21, 2022

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Jun 15, 2022 •
edited
Loading

/node/version now contains an unsafe flag reflecting the status of the build.

@ccf-bot
Copy link
Collaborator

ccf-bot commented Jun 15, 2022 •
edited
Loading

report_unsafe_in_version_endpoint@46806 aka 20220621.21 vs main ewma over 20 builds from 46464 to 46798

Click to see table

main

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
46464 20220614.10 6197.94 8.32349e+07 19724.5 1.56017e+07 5542.74 1.50774e+07 2540.98 1.00967e+07 1600.07 1.62665e+08 2117.97 9.04813e+06 1438.45 9.76528e+07 1937.64 8.78598e+06 17700.5 915189 1.40207e+06 9.30913e+06 3.59298e+07
46477 20220614.14 6200.65 8.3497e+07 19031.6 1.6126e+07 5351.76 1.6126e+07 2529.83 1.00967e+07 1613.02 1.62927e+08 2108.98 9.04813e+06 1420.71 9.81771e+07 1973.65 8.78598e+06 21215.2 907273 1.35934e+06 9.25851e+06 3.58042e+07
46482 20220614.16 6262.47 8.37592e+07 19537 1.58639e+07 5619.87 1.53396e+07 2546.63 1.00967e+07 1649.72 1.63189e+08 2125.28 9.04813e+06 1443.97 9.87014e+07 1940.03 8.78598e+06 19539.4 897728 1.35709e+06 9.20445e+06 3.58042e+07
46491 20220614.20 6092.58 8.84778e+07 19597.9 1.58639e+07 5614.87 1.48153e+07 2548.7 1.00967e+07 1605.31 1.63451e+08 2115.19 9.04813e+06 1431.83 9.84392e+07 1910.31 8.78598e+06 17119.2 913912 1.36669e+06 9.35583e+06 3.62478e+07
46508 20220614.26 6279.28 8.3497e+07 19652.4 1.56017e+07 5554.16 1.56017e+07 2550.44 1.00967e+07 1620.11 1.63189e+08 2122.38 9.04813e+06 1445.76 9.81771e+07 1973.36 8.78598e+06 19699.7 924349 1.37893e+06 9.4074e+06 3.59292e+07
46536 20220615.2 6351.21 8.29727e+07 19517.9 1.58639e+07 5558.18 1.50774e+07 2546.59 1.00967e+07 1636.92 1.62927e+08 2114.82 9.04813e+06 1448.16 9.79149e+07 1939.32 8.78598e+06 19691.3 889850 1.37708e+06 9.22103e+06 3.54325e+07
46550 20220615.6 6300.22 8.27106e+07 20268.8 1.58639e+07 5589.14 1.53396e+07 2549.9 1.00967e+07 1620.36 1.63451e+08 2100.84 9.04813e+06 1430.81 9.84392e+07 1971.94 8.78598e+06 17384.5 889500 1.40581e+06 9.46391e+06 3.58669e+07
46582 20220615.19 6404.67 8.37592e+07 20021.9 1.58639e+07 5629.86 1.56017e+07 2539.83 1.00967e+07 1624.3 1.63189e+08 2112.53 9.31027e+06 1435.85 9.84392e+07 2013.46 8.78598e+06 19158.7 906389 1.43437e+06 9.24597e+06 3.39073e+07
46589 20220616.1 6471.44 8.37592e+07 20351.8 1.66503e+07 5732.22 1.53396e+07 2554.17 1.14074e+07 1650.33 1.63451e+08 2124.5 9.31027e+06 1444.36 9.81771e+07 2016.27 9.04813e+06 19668.5 867241 1.31602e+06 9.00608e+06 3.5128e+07
46651 20220617.3 6432.37 8.32349e+07 19902.5 1.66503e+07 5564.93 1.53396e+07 2602.69 1.00967e+07 1637.48 1.61354e+08 2114.21 9.31027e+06 1428.81 9.76528e+07 1920.21 9.04813e+06 19444.2 910820 1.37099e+06 9.14278e+06 3.58663e+07
46655 20220617.5 6582.32 8.37592e+07 20271.4 1.6126e+07 5648.15 1.53396e+07 2541.9 1.00967e+07 1649.28 1.63451e+08 2116.58 1.32424e+07 1443.87 9.81771e+07 1963.89 8.78598e+06 20023.8 930184 1.37255e+06 9.48583e+06 3.66369e+07
46679 20220620.1 6186.76 8.42835e+07 20080.4 1.63882e+07 5783.09 1.50774e+07 2544.23 1.00967e+07 1645.83 1.63451e+08 2127.26 9.31027e+06 1437.49 9.81771e+07 1931.89 9.04813e+06 20588.6 902596 1.37921e+06 9.26274e+06 3.59298e+07
46708 20220620.12 6410.18 8.3497e+07 20046.9 1.63882e+07 5522.76 1.53396e+07 2545.31 1.00967e+07 1612.62 1.63189e+08 2108.99 9.04813e+06 1432.94 9.81771e+07 1929.21 9.04813e+06 19234.3 883667 1.38172e+06 9.18382e+06 3.54939e+07
46732 20220620.23 6276.97 8.32349e+07 20367.7 1.58639e+07 5667.8 1.50774e+07 2531.36 1.00967e+07 1646.82 1.62927e+08 2114.54 9.31027e+06 1399.96 9.81771e+07 1975.71 8.78598e+06 17876.3 907078 1.37045e+06 9.12656e+06 3.58042e+07
46741 20220620.26 6515.01 8.3497e+07 19127.8 1.58639e+07 5749.39 1.50774e+07 2596.32 1.00967e+07 1626.13 1.63189e+08 2115.71 9.31027e+06 1437.82 9.81771e+07 1971.93 8.78598e+06 19986.1 873493 1.38033e+06 9.20859e+06 3.57417e+07
46755 20220620.33 5854.04 8.37592e+07 19968 1.58639e+07 5638.65 1.56017e+07 2528.41 1.00967e+07 1615.92 1.63451e+08 2078.47 9.57242e+06 1441.23 9.79149e+07 1932.26 8.78598e+06 19767.7 909413 1.35737e+06 9.326e+06 3.58669e+07
46766 20220621.5 6401.03 8.3497e+07 19861.6 1.58639e+07 5667.98 1.53396e+07 2611.12 1.00967e+07 1615.19 1.62927e+08 2132.03 9.57242e+06 1443.54 9.84392e+07 2010.31 8.78598e+06 19602.3 924348 1.35422e+06 9.26274e+06 3.61199e+07
46769 20220621.6 6611.97 8.40213e+07 19570.5 1.6126e+07 5585.44 1.56017e+07 2551.57 1.00967e+07 1639.97 1.63713e+08 2122.99 9.31027e+06 1444.67 9.81771e+07 2025.16 8.78598e+06 21098.4 928835 1.37754e+06 9.34729e+06 3.53713e+07
46791 20220621.15 6397.4 8.40213e+07 20019.4 1.58639e+07 5665.02 1.53396e+07 2549.13 1.00967e+07 1601.71 1.62927e+08 2123.38 9.31027e+06 1415.65 9.81771e+07 1928.49 9.04813e+06 19934.2 876595 1.40572e+06 9.31748e+06 3.55556e+07
46798 20220621.18 6132.98 8.29727e+07 20152.9 1.6126e+07 5663.11 1.53396e+07 2551.27 9.83456e+06 1618.06 1.63189e+08 2132.93 9.31027e+06 1429.32 9.81771e+07 2020.55 8.78598e+06 19580.5 908764 1.40678e+06 9.30482e+06 3.58663e+07

report_unsafe_in_version_endpoint

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
46667 20220617.10 6419.91 8.45456e+07 19573.3 1.58639e+07 5601.89 1.50774e+07 2538.58 1.00967e+07 1612.35 1.62927e+08 2116.14 9.31027e+06 1437.47 9.81771e+07 2004.73 9.04813e+06 20629.5 881038 1.37245e+06 9.39006e+06 3.65714e+07
46752 20220620.31 6146.9 8.37592e+07 20071 1.66503e+07 5664.22 1.53396e+07 2536.57 1.03588e+07 1628.1 1.62927e+08 2110.07 9.04813e+06 1435.72 9.81771e+07 1967.18 9.04813e+06 19456.4 902678 1.37542e+06 9.22934e+06 3.56168e+07
46765 20220621.4 6351.19 8.32349e+07 19718.1 1.69124e+07 5593.19 1.56017e+07 2535.96 1.00967e+07 1612.2 1.63451e+08 2122.77 9.04813e+06 1434.76 9.84392e+07 1910.75 9.04813e+06 19440.3 900531 1.39452e+06 9.28794e+06 3.65714e+07
46797 20220621.17 6461.71 8.3497e+07 19792.8 1.63882e+07 5639.89 1.53396e+07 2483.1 1.00967e+07 1575.82 1.63189e+08 2144.98 9.04813e+06 1421.13 9.84392e+07 1931.61 9.04813e+06 19097.8 910014 1.37412e+06 9.3601e+06 3.5128e+07
46806 20220621.21 6004.02 8.40213e+07 19428 1.6126e+07 5683.06 1.53396e+07 2605.62 1.00967e+07 1629.25 1.63451e+08 2109.42 9.57242e+06 1417.48 9.84392e+07 1928.5 9.04813e+06 19292.3 906228 1.37578e+06 9.26274e+06 3.58669e+07

images

@achamayou achamayou marked this pull request as ready for review June 17, 2022 17:22
@achamayou achamayou requested a review from a team as a code owner June 17, 2022 17:22
@achamayou achamayou added 2.x-todo PRs which should be backported to 2.x auto-backport Automatically backport this PR to LTS branch labels Jun 20, 2022
@achamayou achamayou enabled auto-merge (squash) June 20, 2022 23:12
@achamayou achamayou merged commit ad3fb89 into microsoft:main Jun 21, 2022
@github-actions
Copy link

💔 All backports failed

Status Branch Result
❌ release/2.x Backport failed because of merge conflicts

You might need to backport the following PRs to release/2.x:
- Describe forwarding behaviour in generated OpenAPI (#3935)

Manual backport

To create the backport manually run:

backport --pr 3942

Questions ?

Please refer to the Backport tool documentation

@github-actions github-actions bot mentioned this pull request Jun 23, 2022
Merged
jumaffre pushed a commit to jumaffre/CCF that referenced this pull request Jun 24, 2022
@achamayou
Reflect unsafe status in /node/version (microsoft#3942)
956a2ed 
(cherry picked from commit ad3fb89)

# Conflicts:
#	CHANGELOG.md
@jumaffre jumaffre mentioned this pull request Jun 24, 2022
Merged
@jumaffre jumaffre added the backported This PR was successfully backported to LTS branch label Jun 24, 2022
jumaffre added a commit that referenced this pull request Jun 24, 2022
@jumaffre @achamayou
Reflect unsafe status in /node/version (#3942) (#3979)
9b86028 
(cherry picked from commit ad3fb89)

# Conflicts:
#	CHANGELOG.md

Co-authored-by: Amaury Chamayou <amchamay@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wintersteiger wintersteiger wintersteiger approved these changes

Assignees
No one assigned
Labels
2.x-todo PRs which should be backported to 2.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achamayou @ccf-bot @wintersteiger @jumaffre