Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger.py: detect malformed entries #4752

Merged
merged 6 commits into from
Dec 16, 2022

Conversation

jumaffre
Copy link
Contributor

Follow-up from #4730

This PR modifies ledger.py slightly so that malformed ledger entries throw an error, rather than proceeding with reading the rest of the malformed ledger/snapshot file without reporting any errors.

@jumaffre jumaffre requested a review from a team as a code owner December 15, 2022 10:22
@ccf-bot
Copy link
Collaborator

ccf-bot commented Dec 15, 2022

ledger_python_malformed_snapshots@58575 aka 20221216.77 vs main ewma over 20 builds from 57967 to 58564

Click to see table

main

build_id build_number Commit latency factor tpcc_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_ls_jwt_virtual_cft^ ls_jwt_virtual_cft^ ls_js_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_full_js_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
57967 20221213.52 0.761508 17161.7 6339.49 8.21863e+07 43775.2 15643.8 1.50774e+07 44567.7 15597 8.78598e+06 13236.2 12490.4 4645.9 5856.8 6.68883e+06 3663.13 5817.83 1.50774e+07 3432.87 1575.7 7.73741e+06 24572.1 1285.81 7.21312e+06 1300.81 6.95098e+06 834640 1.17501e+06 8.16564e+06 3.07877e+07
58016 20221213.65 0.785305 17163 6335.69 8.24484e+07 43759.4 15486.9 1.56017e+07 47159.6 15619.8 8.52384e+06 13374.2 12541 4664.3 5852 6.68883e+06 3692.57 5836.24 1.50774e+07 3442.9 1570.55 7.99955e+06 27891.4 1285.03 7.21312e+06 1306.57 6.95098e+06 834585 1.17872e+06 8.15462e+06 3.14936e+07
58072 20221214.2 0.793672 17173.7 6319.6 8.24484e+07 45293.5 15476.1 1.50774e+07 47904.6 15592.7 8.78598e+06 14153.7 12612 4453.13 5838.9 6.68883e+06 3664.96 5833.02 1.50774e+07 3473.84 1575.52 7.73741e+06 24782.7 1288.52 7.21312e+06 1301.54 6.95098e+06 828456 1.17998e+06 8.13593e+06 3.01442e+07
58130 20221214.21 0.789091 17231.1 5658.97 8.27106e+07 45555 15505.6 1.50774e+07 45172.5 15506.4 8.52384e+06 13279.6 12509.8 4662.74 5851.6 6.68883e+06 3657.87 5830.67 1.50774e+07 3473.39 1571.88 7.73741e+06 23788.3 1280.75 7.21312e+06 1301.01 6.95098e+06 837723 1.17236e+06 8.169e+06 3.07933e+07
58179 20221214.36 0.81309 17238.2 5676.67 8.29727e+07 41767.4 15568.3 1.53396e+07 44824.1 15600.3 8.52384e+06 13140.4 12828.2 4673.11 5811.5 6.68883e+06 3667.3 5810.08 1.45532e+07 3330.51 1563.16 7.73741e+06 27803 1290.39 7.21312e+06 1300.35 6.95098e+06 828430 1.17631e+06 8.15141e+06 3.08824e+07
58194 20221214.40 0.803036 17265.7 6325.57 8.27106e+07 43391.6 15679.6 1.53396e+07 45673.3 15524.8 8.78598e+06 14066 12455.3 4658.23 5847.9 6.68883e+06 3567.46 5809.43 1.48153e+07 3349.57 1561.88 7.99955e+06 26061.5 1288.42 7.21312e+06 1303.16 6.95098e+06 834654 1.17405e+06 8.14823e+06 3.07591e+07
58214 20221214.47 0.773959 17107.7 6292.29 8.24484e+07 43798.8 15698.7 1.50774e+07 47702 15638.2 8.52384e+06 14118.6 13954.9 4643.5 5896.7 6.68883e+06 3630.38 5916.99 1.50774e+07 3412.23 1569.52 7.73741e+06 29421 1293.2 7.47526e+06 1307.76 6.95098e+06 836808 1.17575e+06 8.12499e+06 3.07757e+07
58217 20221214.49 0.782418 17161.6 6373.39 8.21863e+07 43377.1 15715 1.53396e+07 47620.3 15642.3 8.78598e+06 13955.4 12343.3 4515.31 5859.8 6.68883e+06 3526.04 5828.14 1.50774e+07 3342.15 1575.73 7.73741e+06 26253.3 1297.65 7.21312e+06 1296.5 6.95098e+06 827321 1.1782e+06 8.15416e+06 3.11748e+07
58224 20221215.1 0.816366 17212.9 6372.34 8.21863e+07 43691 15572.4 1.50774e+07 46898.1 15698.4 8.78598e+06 13213.4 12375.9 4358.75 5874 6.68883e+06 3681.86 5852.51 1.50774e+07 3414.8 1574.09 7.73741e+06 25218 1293.99 7.47526e+06 1311.84 6.95098e+06 835105 1.17492e+06 8.15605e+06 3.14859e+07
58261 20221215.15 0.821351 17145.3 5689.08 8.29727e+07 43652 15157.3 1.53396e+07 45157.8 15450.3 8.78598e+06 14100 12703.8 4620.27 5807.7 6.68883e+06 3547.15 5820.1 1.48153e+07 3305 1568.01 7.73741e+06 21453 1283.17 7.47526e+06 1300.25 6.95098e+06 840164 1.18013e+06 8.15485e+06 3.08443e+07
58281 20221215.22 0.810639 17275.4 6309.78 8.24484e+07 45627.6 15096 1.50774e+07 44512.1 15515.4 8.78598e+06 13197.2 12546.9 4543.8 5862.9 6.95098e+06 3679.98 5854.86 1.50774e+07 3461.25 1567.29 7.73741e+06 23695.9 1283.36 7.47526e+06 1302.35 6.95098e+06 824933 1.17754e+06 8.0831e+06 3.13447e+07
58303 20221215.29 0.789626 17312.8 6250.99 8.24484e+07 43711.9 15440.1 1.58639e+07 47044.9 15549 8.78598e+06 13189.7 12892 4649.39 5799.3 6.68883e+06 3550.78 5817.07 1.50774e+07 3451.29 1549.88 7.73741e+06 22216.3 1282.49 7.73741e+06 1295.59 6.95098e+06 832871 1.17479e+06 8.14982e+06 3.12048e+07
58329 20221216.2 0.796547 17206.7 6326.76 8.27106e+07 45701.7 15705.8 1.53396e+07 47424.3 15599.6 8.78598e+06 13231.4 12405.6 4508.64 5856.9 6.68883e+06 3684.67 5858.54 1.50774e+07 3393.81 1574.92 7.73741e+06 23914.8 1297.45 7.99955e+06 1300.19 6.95098e+06 837728 1.17831e+06 8.15244e+06 3.10501e+07
58381 20221216.18 0.785684 17079.7 6305.51 8.24484e+07 45817 15690.5 1.50774e+07 44478.1 15643.7 8.52384e+06 13992.3 12756.9 4482.52 5886.7 6.68883e+06 3507.86 5816.74 1.50774e+07 3406.87 1574.32 7.73741e+06 24775.1 1289.65 7.21312e+06 1295.35 6.95098e+06 839803 1.17401e+06 8.14965e+06 3.07688e+07
58410 20221216.27 0.781704 17216.3 6273.26 8.27106e+07 46083 15552.4 1.53396e+07 45031.6 15652.7 8.52384e+06 14050.8 12372.5 4615.19 5872.7 6.68883e+06 3672.22 5855.77 1.48153e+07 3446.34 1573.95 7.73741e+06 20729.1 1294.45 7.47526e+06 1310.73 6.95098e+06 839064 1.17764e+06 8.11858e+06 3.07212e+07
58467 20221216.45 0.77956 17312 6317.99 8.21863e+07 45546.8 15432.5 1.50774e+07 47797.1 15639 8.52384e+06 13154.2 12521.3 4474.63 5846.5 6.68883e+06 3675.57 5827.42 1.50774e+07 3428.61 1573.39 7.73741e+06 21478.3 1286.16 7.21312e+06 1299.31 6.95098e+06 839459 1.17545e+06 8.15274e+06 3.07938e+07
58496 20221216.54 0.790146 17103 6290.83 8.24484e+07 45944.6 15564.5 1.53396e+07 48014.6 15628.7 8.78598e+06 14034.2 12461.5 4524.87 5822 6.68883e+06 3603.96 5825.66 1.48153e+07 3477.23 1571.06 7.73741e+06 31808.9 1285.15 7.21312e+06 1294.35 6.95098e+06 838421 1.17735e+06 8.17457e+06 3.07397e+07
58519 20221216.61 0.789466 17210 6280.07 8.24484e+07 43634.4 15566.2 1.50774e+07 45387.2 15485.7 9.04813e+06 13156.6 14058.9 4666.36 5765.8 6.68883e+06 3631.49 5854.58 1.50774e+07 3466.25 1569.4 7.73741e+06 26245.1 1282.84 7.21312e+06 1298.54 6.95098e+06 832359 1.1848e+06 8.15429e+06 3.09193e+07
58557 20221216.71 0.800597 17301.8 6280.32 8.1662e+07 46004 15411 1.50774e+07 47919.9 15509.3 8.78598e+06 13872.5 12651.6 4449.92 5820.7 6.68883e+06 3683.95 5789.44 1.50774e+07 3368.16 1559.72 7.73741e+06 23621.3 1278.35 7.21312e+06 1291.69 6.95098e+06 832559 1.174e+06 8.17294e+06 3.06931e+07
58564 20221216.74 0.78089 17301.9 6290.97 8.24484e+07 43767.2 15439.2 1.50774e+07 47750.2 15585 8.78598e+06 13188.3 12678 4502.83 5822.2 6.68883e+06 3657.81 5840.05 1.48153e+07 3477.77 1568.1 7.73741e+06 23866.1 1279.27 7.21312e+06 1288.79 6.95098e+06 825428 1.1767e+06 8.17206e+06 3.12119e+07

ledger_python_malformed_snapshots

build_id build_number Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem pi_ls_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_jwt_virtual_cft^ ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_js_jwt_virtual_cft^ hist_sgx_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
58302 20221215.28 0.787762 17213.7 45951.4 6319.87 8.27106e+07 47574.7 15774.9 1.53396e+07 13966.8 12282.8 4493.51 3549.24 15663.4 8.52384e+06 3391.46 23355.7 5862.6 6.68883e+06 5875.32 1.4291e+07 1572.94 7.73741e+06 1285.13 7.21312e+06 1314.05 6.95098e+06 831954 1.17941e+06 8.15222e+06 3.11791e+07
58324 20221215.35 0.78753 16737.7 45832.6 6311.46 8.24484e+07 47876.2 15734.3 1.50774e+07 13993.7 14068.8 4651.85 3528.99 15627.7 8.52384e+06 3486.33 24180.3 5908 6.68883e+06 5837.76 1.50774e+07 1575.88 7.73741e+06 1292.88 7.47526e+06 1311.26 6.95098e+06 835830 1.17988e+06 8.17376e+06 3.07471e+07
58515 20221216.59 0.806067 17351.4 45912.2 6259.17 8.19242e+07 45411.2 15428.5 1.53396e+07 13290.8 12523.8 4684.39 3647.35 15593.5 8.52384e+06 3457.29 29400.8 5812.6 6.68883e+06 5828.3 1.50774e+07 1553.52 7.73741e+06 1274.91 7.21312e+06 1289.15 6.95098e+06 823909 1.17579e+06 8.15722e+06 3.09506e+07
58542 20221216.67 0.808952 17259.2 43700.3 5702.08 8.32349e+07 47636.2 15488.8 1.53396e+07 12712.5 12364.9 4535.1 3697.3 15562.6 8.78598e+06 3307.14 25950.4 5822.3 6.68883e+06 5802.2 1.48153e+07 1561.29 7.73741e+06 1286.07 7.21312e+06 1299.48 6.95098e+06 841440 1.17701e+06 8.15559e+06 3.09979e+07
58575 20221216.77 0.797246 17151 43694.8 6354.06 8.27106e+07 48259.2 15516.9 1.53396e+07 14103.5 12510.1 4576.24 3652.31 15637 8.52384e+06 3457.51 21578.2 5869.9 6.68883e+06 5816.77 1.50774e+07 1577.52 7.73741e+06 1285.22 7.47526e+06 1295.36 6.95098e+06 830355 1.18037e+06 8.17447e+06 3.07965e+07

images

@jumaffre jumaffre enabled auto-merge (squash) December 15, 2022 17:54
@jumaffre jumaffre merged commit 6c8e0e4 into microsoft:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants