Support for HTTP in the CI #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
=========================================
+ Coverage 78.54% 78.6% +0.07%
=========================================
Files 140 140
Lines 10478 10501 +23
=========================================
+ Hits 8229 8254 +25
+ Misses 2249 2247 -2
|
eddyashton
reviewed
Nov 12, 2019
eddyashton
reviewed
Nov 12, 2019
eddyashton
reviewed
Nov 12, 2019
eddyashton
reviewed
Nov 12, 2019
achamayou
approved these changes
Nov 13, 2019
added 2 commits
November 13, 2019 09:05
|
|
olgavrou
approved these changes
Nov 13, 2019
eddyashton
pushed a commit
to eddyashton/CCF
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces HTTP as a separate job on the CI. For now, it only runs against Raft and NoSGX (*).
e2e_test.pyas we now run most of our tests in HTTP.tests/infra/consortium.pynow uses Python instead ofmemberclientas much as possible, i.e. everything except signed requests.new_usermember RPC is now written in C++ so that members can submit a new user/member certificate in PEM to be recorded in the KV as DER. The translation from PEM to DER is now pushed to the server.This also fixes a small bug with the HTTP
RPCClientin the enclave (used for the join protocol) so that our tests now support multiple node with(*) NoSGX and not SGX for now as large HTTP requests seem to stall CCF #548
Further HTTP work can be tracked under the
httplabel: http