Receipts #567
Merged
Receipts #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
==========================================
- Coverage 78.56% 78.47% -0.09%
==========================================
Files 140 140
Lines 10567 10646 +79
==========================================
+ Hits 8301 8354 +53
- Misses 2266 2292 +26
|
jumaffre
reviewed
Nov 18, 2019
jumaffre
reviewed
Nov 18, 2019
|
|
olgavrou
reviewed
Nov 19, 2019
|
|
|
|
jumaffre
reviewed
Nov 19, 2019
jumaffre
reviewed
Nov 19, 2019
|
Could this new feature be (briefly) documented here: https://microsoft.github.io/CCF/users/issue_commands.html#checking-for-commit? |
|
@jumaffre sure, I'll make it short for now because I'm planning to do a single txInfo RPC as discussed. |
|
|
eddyashton
reviewed
Nov 19, 2019
|
|
jumaffre
reviewed
Nov 20, 2019
|
|
|
|
ashamis
approved these changes
Nov 20, 2019
olgavrou
approved these changes
Nov 20, 2019
eddyashton
approved these changes
Nov 20, 2019
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #56
Basic receipts support for CCF, subject to the compaction limit.
As a follow up to this, we should write the serialised tree in signature Txs, and sync up compaction with commit, to allow historical verification.