Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating x25519 key pairs from JS #5846

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Nov 24, 2023

ccf.crypto.generateEddsaKeyPair, pubEddsaPemToJwk and eddsaPemToJwk now support x25519 as well as curve25519.

@ghost
Copy link

ghost commented Nov 24, 2023

js_generate_x25519@79016 aka 20231128.7 vs main ewma over 20 builds from 78732 to 79003

Click to see table

main

build_id build_number pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_basic_mt_virtual_cft^ tpcc_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_virtual_cft^ pi_ls_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_basic_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem pi_basic_js_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ tlc_sim_traces tlc_sim_levelmean
78732 20231114.8 28229 2.51822e+07 0.774127 5532.42 8.59996e+07 13941 1.88908e+07 14054.1 1.05021e+07 15553.4 1.46964e+07 66564.2 17331.9 1425 1.25993e+07 45619.3 49204.6 6799.53 1.67936e+07 54555.9 6917.4 6.30784e+06 4406.9 5804.86 1.67936e+07 17327.4 19269.7 5715.65 1.88908e+07 17568.9 14985.1 3986.94 1.67936e+07 9772.51 117 1.97092e+06 373 1.15766e+07 213 5.93588e+06 44884.8 835689 1.17372e+06 8.13787e+06 3.06941e+07 2465 403
78757 20231114.16 28139 2.30851e+07 0.803877 5583.8 8.59996e+07 13935.2 1.88908e+07 14049.3 1.05021e+07 15547.2 1.46964e+07 78718.2 17247.3 1419 1.25993e+07 45858.6 48158 6840.03 1.88908e+07 54115.8 7094.3 6.30784e+06 4402.2 5792.23 1.67936e+07 17022.2 18957.7 5445.65 1.67936e+07 17599.6 15058.9 3984.71 1.67936e+07 9896.12 114 1.97092e+06 375 1.15766e+07 214 5.93588e+06 45044.2 840346 1.18257e+06 8.14952e+06 3.06403e+07 2550 403
78773 20231115.3 27933.8 2.51822e+07 0.79485 5620.03 8.59996e+07 14014.5 1.88908e+07 14121 1.05021e+07 15699.3 1.25993e+07 81711.5 17152.8 1429.9 1.25993e+07 43748.8 47970.6 6838.2 1.67936e+07 53769.2 6969.8 6.30784e+06 4363.7 5764.54 1.67936e+07 17081.4 19469.3 5701.96 1.67936e+07 17481 14947.9 3993.58 1.67936e+07 9782.8 116 1.97092e+06 379 1.15766e+07 215 5.93588e+06 46835.9 832879 1.17741e+06 8.12624e+06 3.07424e+07 2566 403
78791 20231115.9 28005.9 2.30851e+07 0.778986 5617.96 8.59996e+07 14101.3 1.88908e+07 14149 1.05021e+07 15700 1.25993e+07 86502.4 17100.8 1431.2 1.25993e+07 46034.7 48079.9 6855.88 1.88908e+07 53661.7 7075.4 6.30784e+06 4366.7 5802.59 1.67936e+07 17041.5 19690.5 5481.56 1.67936e+07 17220.4 14782.5 3969 1.67936e+07 10234.7 116 1.97092e+06 382 1.15766e+07 216 5.93588e+06 39934.6 836785 1.17989e+06 8.13648e+06 3.13083e+07 2378 403
78802 20231116.3 28166.8 2.30851e+07 0.811716 5634.31 8.59996e+07 14008.5 1.67936e+07 14135.2 1.05021e+07 15586.7 1.25993e+07 85473.6 17353.7 1438.6 1.25993e+07 45762.7 48685.7 6886.86 1.88908e+07 53421.4 6969.8 6.30784e+06 4382.4 5811.17 1.67936e+07 17202.6 19566.8 5493.13 1.67936e+07 17571.8 14777 3995.67 1.67936e+07 10220.2 117 1.97092e+06 376 1.15766e+07 216 5.93588e+06 40486.2 829407 1.18299e+06 8.16157e+06 3.17642e+07 2541 403
78832 20231116.13 28033.9 2.51822e+07 0.791776 5568.48 8.59996e+07 13975.9 1.88908e+07 14102.4 1.05021e+07 15341.5 1.46964e+07 79471 17231.3 1412.1 1.25993e+07 45591.6 48626.8 6806.16 1.88908e+07 54009.4 7087.3 6.30784e+06 4404.9 5794.87 1.67936e+07 17230.8 19925.9 5465.52 1.67936e+07 17442.3 14946.8 3971.21 1.67936e+07 10055.8 117 1.97092e+06 376 1.15766e+07 218 5.93588e+06 42367.9 832368 1.1798e+06 8.02398e+06 3.09829e+07 2506 403
78842 20231117.3 27900.2 2.30851e+07 0.779099 5498.44 8.59996e+07 14026.5 1.88908e+07 14141.5 1.05021e+07 15578.2 1.46964e+07 69869.4 17251.8 1432.9 1.25993e+07 45714.2 48608.8 7251.7 1.67936e+07 54304.4 6975 6.30784e+06 4409.3 5809.31 1.67936e+07 17192.5 19569.9 5493.79 1.67936e+07 17514.5 14828.9 4001.42 1.67936e+07 10287.4 119 1.97092e+06 383 1.15766e+07 217 5.93588e+06 42299.1 830414 1.17803e+06 8.13105e+06 3.07069e+07 2683 403
78859 20231117.9 28176.7 2.51822e+07 0.774191 5558.52 8.59996e+07 13957.5 1.88908e+07 13981.4 1.05021e+07 15386.2 1.25993e+07 64345.3 17656.4 1411.5 1.25993e+07 45603.9 48606.7 6834.32 1.88908e+07 53134.8 7044.2 6.30784e+06 4393.3 5764.83 1.67936e+07 17108 19854.7 5475.54 1.67936e+07 17259.2 14842.3 3967.94 1.67936e+07 9762.56 6 86496 429 1.2541e+07 233 6.31473e+06 40552.4 822575 1.17989e+06 8.14826e+06 3.1304e+07 2353 403
78867 20231117.11 28011.1 2.51822e+07 0.789259 5532.49 8.59996e+07 13959.9 1.88908e+07 14086.6 1.05021e+07 15607.5 1.46964e+07 84170.9 17234.3 1425.5 1.25993e+07 45769.1 48849.1 7204.68 1.67936e+07 54044.1 6867.2 6.30784e+06 4423.9 5758.27 1.67936e+07 17390.1 19782.8 5485.61 1.67936e+07 17568.6 14961.2 3958.15 1.67936e+07 9856.64 6 86496 427 1.2541e+07 237 6.31473e+06 36013.1 826589 1.1806e+06 8.14554e+06 3.07762e+07 2350 403
78880 20231117.16 28161.2 2.51822e+07 0.80791 5542.17 8.59996e+07 13866.9 1.88908e+07 14091.2 1.05021e+07 15471.7 1.25993e+07 73411.2 17111.4 1417.1 1.25993e+07 45833.7 48652.1 6827.43 1.88908e+07 53480 6878.2 6.30784e+06 4396.7 5754.04 1.67936e+07 17355.1 19287.5 5475.55 1.67936e+07 17410.3 14710.2 3959.62 1.67936e+07 10222.6 6 86496 422 1.2541e+07 236 6.31473e+06 39201.5 826354 1.16751e+06 8.14719e+06 2.96575e+07 2353 403
78893 20231120.3 27855.8 2.51822e+07 0.801322 5526.2 8.59996e+07 14027.1 1.67936e+07 14111.9 1.05021e+07 15491.7 1.46964e+07 86783 17254.2 1434.7 1.25993e+07 45926.8 48881.4 6873.18 1.67936e+07 53738.7 7100 6.30784e+06 4400.6 5809.21 1.67936e+07 17214.3 19693.6 5473.48 1.67936e+07 17299 14827.7 3997.55 1.67936e+07 10378.1 7 86496 437 1.2541e+07 236 6.31473e+06 44585.3 834533 1.18053e+06 8.13657e+06 3.07268e+07 2358 403
78903 20231120.6 27910.1 2.51822e+07 0.776971 5588.84 8.59996e+07 14006.7 1.88908e+07 14128.2 1.05021e+07 15542.6 1.46964e+07 76085.7 17269.9 1424.8 1.25993e+07 45515.5 48925.8 6809.86 1.67936e+07 54607.7 7086.4 6.30784e+06 4396 5801.75 1.67936e+07 17369.1 19187.6 5489.46 1.88908e+07 17262.9 14986.6 3983.82 1.67936e+07 10280.5 6 86496 420 1.2541e+07 235 6.31473e+06 43080.3 825486 1.18067e+06 8.12495e+06 3.07669e+07 2483 403
78910 20231121.2 28064.3 2.30851e+07 0.782815 5637.59 8.59996e+07 14010 1.88908e+07 14094.9 1.05021e+07 15571.5 1.46964e+07 65223.5 17244.7 1429.1 1.25993e+07 45642.1 49335.7 6824.41 1.88908e+07 54540.2 6838 6.30784e+06 4313.9 5801.55 1.67936e+07 17479.7 19872.4 5718.26 1.88908e+07 17539.4 15030.2 3995 1.67936e+07 10014.2 6 86496 430 1.2541e+07 237 6.31473e+06 43312.5 834029 1.1795e+06 8.15254e+06 3.13375e+07 2320 403
78927 20231122.3 28152.8 2.51822e+07 0.779541 5588.18 8.59996e+07 13986.1 1.67936e+07 14144 1.05021e+07 15588.9 1.46964e+07 76409.5 17084.3 1420.9 1.25993e+07 45798 48088.3 7229.81 1.67936e+07 53418.9 6960.4 6.30784e+06 4254.5 5773.09 1.67936e+07 17210.2 19526.3 5484.14 1.67936e+07 17056.3 14794 3956.53 1.67936e+07 10415.8 6 86496 434 1.2541e+07 244 6.31473e+06 39425.7 835102 1.17538e+06 8.1542e+06 3.07641e+07 2169 403
78938 20231123.3 27979.7 2.30851e+07 0.781707 5584.35 8.59996e+07 14005.6 1.88908e+07 14105.7 1.05021e+07 15544.2 1.25993e+07 84840.7 17181.3 1436.1 1.25993e+07 45861.6 47009.9 6833.83 1.88908e+07 53780.2 6933.9 6.30784e+06 4394.1 5775.81 1.67936e+07 17076.9 19139.9 5478.03 1.67936e+07 17680.5 15024.3 3965.62 1.67936e+07 10344.6 6 86496 444 1.2541e+07 237 6.31473e+06 42442.2 837732 1.17488e+06 8.13131e+06 3.10242e+07 2315 403
78946 20231123.6 28061.1 2.51822e+07 0.777791 5658.72 8.59996e+07 14089.8 1.88908e+07 14141.3 1.05021e+07 15596.4 1.46964e+07 86883.8 17204.7 1436.5 1.25993e+07 45889 48275.8 6820.49 1.67936e+07 54039 7089.5 6.30784e+06 4404.6 5810.57 1.67936e+07 17189.6 19639.8 5486.29 1.67936e+07 17558.8 14931 4000.23 1.67936e+07 10417.5 7 86496 427 1.2541e+07 237 6.31473e+06 47220.7 839400 1.18506e+06 8.13564e+06 3.09965e+07 2153 403
78953 20231123.8 27789.8 2.51822e+07 0.810533 5604.37 8.59996e+07 14030.4 1.88908e+07 14076.6 1.05021e+07 15674 1.46964e+07 75339 17264.5 1437.1 1.25993e+07 45863.8 49175.8 6830.93 1.67936e+07 53925.3 6958.4 6.30784e+06 4391.7 5765.5 1.67936e+07 17295.3 19719.6 5731.04 1.88908e+07 17605.8 14888.2 3993.18 1.67936e+07 10394.9 6 86496 420 1.2541e+07 237 6.31473e+06 45694.6 829649 1.17942e+06 8.14279e+06 3.07688e+07 2331 403
78967 20231124.2 27595.4 2.51822e+07 0.782565 5619.27 8.59996e+07 14047.6 1.88908e+07 14120.8 1.05021e+07 15603.3 1.46964e+07 72019.2 17245.4 1434.1 1.25993e+07 45777.6 49218.4 6862.89 1.88908e+07 54646.7 7057.8 6.30784e+06 4429.9 5805.21 1.67936e+07 17407.9 19488.2 5477.8 1.67936e+07 17750.3 14995.5 3995.96 1.67936e+07 10073.9 6 86496 439 1.2541e+07 240 6.31473e+06 43678.4 833717 1.17934e+06 8.1552e+06 3.07882e+07 2280 403
78987 20231127.2 27968.2 2.30851e+07 0.791971 5574.76 8.59996e+07 14018.8 1.67936e+07 14108.5 1.05021e+07 15515 1.46964e+07 72391.9 17383.7 1433.2 1.25993e+07 45643.3 47824.5 7228.12 1.67936e+07 52921.6 7141.5 6.30784e+06 4384.3 5801.53 1.67936e+07 17164.6 19797.7 5724.29 1.88908e+07 17253.6 14765 3966.89 1.67936e+07 10224.5 6 86496 424 1.2541e+07 238 6.31473e+06 39610.6 828249 1.18027e+06 8.13531e+06 3.11147e+07 2249 403
79003 20231128.3 28069.8 2.51822e+07 0.808064 5630.81 8.59996e+07 14033.1 1.88908e+07 14112.5 1.05021e+07 15713.1 1.25993e+07 74088.1 17241.6 1443.3 1.25993e+07 45776.3 49222.8 7243.52 1.67936e+07 54048.1 6982.1 6.30784e+06 4425.8 5774.56 1.67936e+07 17355.8 19581 5499.24 1.67936e+07 17718.1 14977.7 4000 1.67936e+07 10405.5 6 86496 436 1.2541e+07 238 6.31473e+06 45424.2 832500 1.18572e+06 8.1335e+06 3.08016e+07 2261 403

js_generate_x25519

build_id build_number pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem pi_basic_mt_virtual_cft^ Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem pi_basic_virtual_cft^ pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem ls_full_js_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_js_jwt_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem hist_sgx_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem tlc_3node_fixed_duration_s tlc_3node_fixed_states tlc_atomic_reconfig_duration_s tlc_atomic_reconfig_states tlc_reconfig_duration_s tlc_reconfig_states RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ tlc_sim_traces tlc_sim_levelmean
78980 20231124.6 28000.3 2.51822e+07 90161 0.79056 17148.5 43715.2 47162.9 5541.51 8.59996e+07 54752.6 4415.8 17232.1 19641 17596.5 13994.5 1.88908e+07 14908.4 14019.4 1.05021e+07 15485.2 1.46964e+07 9754.07 1417.9 1.25993e+07 41155.6 6831.04 1.88908e+07 7042.2 6.30784e+06 5796.45 1.67936e+07 5737.41 1.88908e+07 4000.11 1.67936e+07 6 86496 434 1.2541e+07 237 6.31473e+06 832487 1.1801e+06 8.13047e+06 3.08346e+07 2460 403
78993 20231127.5 27769.6 2.30851e+07 66695.7 0.793002 17287.3 43619.7 47654 5631.94 8.59996e+07 54362.6 4343.9 17232 19114.6 17513.3 14066.2 1.67936e+07 14998.2 14112.5 1.05021e+07 15640.7 1.46964e+07 10081.1 1430.4 1.25993e+07 46451.8 6842 1.88908e+07 7092.3 6.30784e+06 5753.85 1.67936e+07 5478.78 1.67936e+07 3994.42 1.67936e+07 6 86496 423 1.2541e+07 235 6.31473e+06 830213 1.18268e+06 8.13664e+06 2.97113e+07 2247 403
79008 20231128.5 27957.7 2.30851e+07 77569.8 0.787738 17258.4 45542.8 47962.8 5614.04 8.59996e+07 54644.7 4358.9 17158.2 19086.2 17388.5 14079.3 1.88908e+07 14784.3 14126.1 1.05021e+07 15574.8 1.46964e+07 10369.3 1430.3 1.25993e+07 41865.8 6840.39 1.88908e+07 6954.9 6.30784e+06 5811.56 1.67936e+07 5760.09 1.67936e+07 3995.16 1.67936e+07 6 86496 411 1.2541e+07 235 6.31473e+06 834813 1.18032e+06 8.15348e+06 3.15665e+07 2290 403
79016 20231128.7 27860.4 2.30851e+07 88261.8 0.803798 17370.4 43554.8 43815.3 5562.45 8.59996e+07 52094.3 4241.2 17235.9 19024.4 17330.8 13948.3 1.88908e+07 14827.7 14069.9 1.05021e+07 15438.7 1.46964e+07 9846.87 1415 1.25993e+07 45535.1 7234.92 1.67936e+07 6915.1 6.30784e+06 5804.72 1.67936e+07 5459.18 1.67936e+07 3987.95 1.67936e+07 7 86496 439 1.2541e+07 236 6.31473e+06 835254 1.17252e+06 8.16105e+06 3.07678e+07 2310 403

images

@achamayou achamayou marked this pull request as ready for review November 27, 2023 11:01
@achamayou achamayou requested a review from a team November 27, 2023 11:01
Copy link
Collaborator

@KenGordon KenGordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@achamayou achamayou enabled auto-merge (squash) November 28, 2023 17:12
@achamayou achamayou merged commit 3882284 into microsoft:main Nov 28, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants