-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mandate that signed payloads are endpoint-specific and timestamped in Programmability sample #6285
Merged
achamayou
merged 18 commits into
microsoft:main
from
achamayou:timestamped_user_cose_sign1
Jun 26, 2024
Merged
Mandate that signed payloads are endpoint-specific and timestamped in Programmability sample #6285
achamayou
merged 18 commits into
microsoft:main
from
achamayou:timestamped_user_cose_sign1
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
commented
Jun 21, 2024
eddyashton
reviewed
Jun 24, 2024
eddyashton
reviewed
Jun 24, 2024
eddyashton
reviewed
Jun 24, 2024
achamayou
commented
Jun 24, 2024
eddyashton
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See remaining item on #6223. Introduce
DynamicJSEndpointRegistry::record_action_details_for_audit_v1
andDynamicJSEndpointRegistry::is_original_action_execution_v1
to allow an application making use of the programmability feature to easily implement auditability, and protect users allowed to update the application against replay attacks.This allows an application to define two parameters in the protected header of COSE Sign1 envelopes, for the purposes of:
I have hardcoded the window size for now, but moving it to the runtime_options may be a good idea, perhaps as
cose_replay_protection_window_size
, or something similar. It's difficult to imagine this being useful though.