Add a nonstd::camel_case util function
#6349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
reviewed
Jul 10, 2024
| @@ -288,4 +292,32 @@ namespace ccf::nonstd | |||
|
|
|||
| return resolved.lexically_normal().string(); | |||
| } | |||
|
|
|||
| static inline std::string camel_case( | |||
There was a problem hiding this comment.
Let's start a src/ds/nonstd.cpp and stop inlining everything.
There was a problem hiding this comment.
Actually let's not export that in public headers either.
achamayou
approved these changes
Jul 10, 2024
|
FYI: Trying this PR out in the context of #6326 right now. |
|
@eddyashton Would camel-casing all-caps strings such as "POST", "DELETE", ... also be an input that the function could/should accept? |
|
Flattened this into #6326, will add followup (making definition private) next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for
https://github.com/microsoft/CCF/pull/6326#issuecomment-2214510569, potentially other situations.