-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [DRAFT] COSE back-endorsements #6510
base: main
Are you sure you want to change the base?
[WIP] [DRAFT] COSE back-endorsements #6510
Conversation
…m:maxtropets/CCF into f/6500-cose-service-identity-endorsements
src/service/internal_tables_access.h
Outdated
ccf::Tables::PREVIOUS_SERVICE_IDENTITY_ENDORSEMENT); | ||
try | ||
{ | ||
const auto pubkey = ccf::crypto::public_key_pem_from_cert( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To discuss if this must be moved to the final recovery TX, or can stay in here.
Pros for leaving it as is
- simplifies chain lookup
Cons
- not really safe to endorse smth with the service key until members have signed off service opening
However
- If recovery isn't completed - the incomplete endorsement will be lost
- During recovery we won't produce endorsements anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked offline, agreed we'll move it to the opening TX to avoid doing things during recovery which are not really needed for recovery, and producing back endorsements seems like one of them.
Closes #6500