Minimize number of TLC configuration files. #6511
Conversation
lemmy
force-pushed
the
mku-singleconfig
branch
from
fc978c3
to
20f09f2
Compare
lemmy
force-pushed
the
mku-singleconfig
branch
3 times, most recently
from
0b7864b
to
b858c90
Compare
Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy
force-pushed
the
mku-singleconfig
branch
from
b858c90
to
99641bf
Compare
There was a problem hiding this comment.
Thanks @lemmy for doing this! The duplication across cfg files meant it was tricky to always keep them all in sync
| run: | | ||
| set -x | ||
| cd tla/ | ||
| ./tlc.sh -workers auto -config consensus/MCccfraftWithReconfig.cfg consensus/MCccfraft.tla -dumpTrace tla MCccfraftWithReconfig.trace.tla -dumpTrace json MCccfraftWithReconfig.json | ||
| Configurations=3C2N MaxTermLimit=4 RequestLimit=1 NoCheckQuorum= ./tlc.sh -workers auto consensus/MCccfraft.tla -dumpTrace tla MCccfraft3C2N4T1R.trace.tla -dumpTrace json MCccfraft3C2N4T1R.json |
There was a problem hiding this comment.
Maybe its just me but I find NoCheckQuorum= a bit confusing, maybe DisableCheckQuourm=True would be clearer?
| run: | | ||
| set -x | ||
| cd tla/ | ||
| ./tlc.sh -workers auto consensus/MCccfraft.tla -dumpTrace tla MCccfraft.trace.tla -dumpTrace json MCccfraft.json | ||
| Configurations=1C2N MaxTermLimit=2 RequestLimit=3 ./tlc.sh -workers auto consensus/MCccfraft.tla -dumpTrace tla MCccfraft1C2NT2R3.trace.tla -dumpTrace json MCccfraft1C2NT2R3.json |
There was a problem hiding this comment.
@lemmy I failed to spot this, but MaxTermLimit=2 here replaces MaxTermLimit=4 that was set in MCccftraft2Nodes.cfg, and effectively means we no longer do view changes in this invocation, or the one below. I am replacing the Limit with a Count, to make it clear that it's the changes from StartTerm that we are setting.
There was a problem hiding this comment.
+1 for changed to term count. If no view change then TermCount should be 0 so it's clear that that is the case
|
A follow-up is to figure out how to run different logical configs in IDEs such as VSCode or the Toolbox. |
|
That's a good point, I guess we are now further away from #6490 |
Consolidate config files to reduce redundancy: The previous setup included multiple config files with mostly similar content. This commit replaces the individual config files with a single unified config file and introduces environment variables to handle differences.