Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run multiple threads for PBFT #838

Merged
merged 5 commits into from
Feb 13, 2020
Merged

Run multiple threads for PBFT #838

merged 5 commits into from
Feb 13, 2020

Conversation

ashamis
Copy link
Contributor

@ashamis ashamis commented Feb 13, 2020

No description provided.

@ashamis ashamis requested a review from a team as a code owner February 13, 2020 13:19
@codecov-io
Copy link

codecov-io commented Feb 13, 2020

Codecov Report

Merging #838 into master will increase coverage by 2.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #838      +/-   ##
==========================================
+ Coverage   77.94%   80.33%   +2.39%     
==========================================
  Files         154      131      -23     
  Lines       11568    10360    -1208     
==========================================
- Hits         9016     8322     -694     
+ Misses       2552     2038     -514
Flag Coverage Δ
#e2e_BFT ?
#e2e_CFT 70.04% <ø> (-2.22%) ⬇️
#unit_BFT ?
#unit_CFT 68.69% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/consensus/pbft/pbftrequests.h 0% <0%> (-94.44%) ⬇️
src/apps/luageneric/luageneric.cpp 86.87% <0%> (ø) ⬆️
src/node/rpc/frontend.h 67.32% <0%> (-9.34%) ⬇️
src/node/rpc/commonhandlerregistry.h 61.08% <0%> (-1.8%) ⬇️
src/enclave/rpcsessions.h 92.86% <0%> (-3.57%) ⬇️
src/kv/kvtypes.h 48.28% <0%> (-3.45%) ⬇️
src/node/rpc/memberfrontend.h 84.71% <0%> (ø) ⬆️
src/node/nodetonode.h 85.23% <0%> (-2.27%) ⬇️
src/luainterp/luajson.h 93.86% <0%> (ø) ⬆️
src/enclave/rpccontext.h 84.85% <0%> (-1.52%) ⬇️
... and 20 more

@ghost
Copy link

ghost commented Feb 13, 2020

worker_threads@4922 aka 20200213.25 vs master ewma over 30 builds from 4542 to 4911
images

@ashamis ashamis merged commit a022b2f into microsoft:master Feb 13, 2020
@ashamis ashamis linked an issue Feb 13, 2020 that may be closed by this pull request
@ashamis ashamis added this to the Performance improvements milestone Feb 17, 2020
@ashamis ashamis deleted the worker_threads branch February 26, 2020 21:31
eddyashton pushed a commit to eddyashton/CCF that referenced this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Threading in CCF
5 participants