Member signed RPC #911
Merged
Member signed RPC #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 3, 2020 11:36
jumaffre
commented
Mar 3, 2020
|
memberfrontend_signed_rpc@5613 aka 20200303.60 vs master ewma over 25 builds from 5233 to 5601 |
olgavrou
reviewed
Mar 3, 2020
olgavrou
approved these changes
Mar 3, 2020
eddyashton
reviewed
Mar 3, 2020
eddyashton
reviewed
Mar 3, 2020
added 2 commits
March 3, 2020 14:06
eddyashton
reviewed
Mar 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #911 +/- ##
===========================================
- Coverage 69.27% 52.19% -17.08%
===========================================
Files 100 95 -5
Lines 7832 6850 -982
===========================================
- Hits 5425 3575 -1850
- Misses 2407 3275 +868
|
eddyashton
approved these changes
Mar 3, 2020
achamayou
reviewed
Mar 3, 2020
…nto memberfrontend_signed_rpc
achamayou
approved these changes
Mar 3, 2020
eddyashton
pushed a commit
to eddyashton/CCF
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCF now enforces that handlers installed with
require_client_signatureare called by a signed client request. This is the case formembers/propose, members/vote, members/complete, members/withdraw`.