Structured RPC responses #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
structured_responses@5779 aka 20200306.16 vs master ewma over 30 builds from 5403 to 5772 |
achamayou
approved these changes
Mar 6, 2020
olgavrou
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #924.
We had a bunch of RPCs that returned the body
true. Many of these would only ever returntrue, so I've removed this and now they return no body at all (their success is indicated by200 OK).Some of these RPCs would sometimes return the body
false, but the meaning of this was unclear. In particular, for/members/vote, a false could mean "there aren't enough yes votes" or "there are too many no votes" or "there were enough yes votes but something went wrong"*. These member RPCs now return a structuredProposalInfoobject.* This case is particularly bad, and now it produces its own new
FAILEDstate - if a proposed action has preconditions, the member votes should probably be checking those preconditions are met!