Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Open Enclave #990

Merged
merged 3 commits into from
Mar 24, 2020
Merged

Upgrade Open Enclave #990

merged 3 commits into from
Mar 24, 2020

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Mar 24, 2020

Update Open Enclave for 0.9 to enable snmalloc use.

fix #980

@achamayou achamayou requested a review from a team as a code owner March 24, 2020 18:05
@@ -91,7 +91,7 @@ if(USE_NULL_ENCRYPTOR)
endif()

option(SAN "Enable Address and Undefined Behavior Sanitizers" OFF)
option(DISABLE_QUOTE_VERIFICATION "Disable quote verification" OFF)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary, until the ACC outage gets resolved.

@codecov-io
Copy link

Codecov Report

Merging #990 into master will increase coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #990      +/-   ##
==========================================
+ Coverage   67.75%   68.17%   +0.42%     
==========================================
  Files         103      103              
  Lines        8250     8250              
==========================================
+ Hits         5589     5624      +35     
+ Misses       2661     2626      -35     
Flag Coverage Δ
#unit_CFT 68.17% <ø> (+0.42%) ⬆️
Impacted Files Coverage Δ
src/tls/entropy.h 21.05% <0.00%> (-52.63%) ⬇️
src/tls/keypair.h 74.38% <0.00%> (-0.31%) ⬇️
src/ds/ringbuffer.h 92.93% <0.00%> (+0.54%) ⬆️
src/tls/intel_drng.h 61.42% <0.00%> (+35.43%) ⬆️

@cimetrics
Copy link

oe_upgrade@6356 aka 20200324.24 vs master ewma over 30 builds from 6003 to 6310
images

@achamayou achamayou merged commit 63e9b6b into microsoft:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update playbooks, CI & perf env to use snmalloc
4 participants