Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Js(Copy|Create)PropertyIdUtf8 to Js(Copy|Create)PropertyId #42

Merged
merged 2 commits into from
Aug 22, 2017
Merged

Rename Js(Copy|Create)PropertyIdUtf8 to Js(Copy|Create)PropertyId #42

merged 2 commits into from
Aug 22, 2017

Commits on Aug 22, 2017

  1. Rename JsCopyPropertyIdUtf8 to JsCopyPropertyId 

    There is no exported function called JsCopyPropertyIdUtf8, but there is JsCopyPropertyId,
declared in ChakraCore.h. So update the doc to match the source code.
    @xiaoyinl
    xiaoyinl committed Aug 22, 2017
    Configuration menu
    Copy the full SHA
    8d88a71 View commit details
    Browse the repository at this point in the history

  2. Rename JsCreatePropertyIdUtf8 to JsCreatePropertyId 

    There is no exported function called JsCreatePropertyIdUtf8, but there is JsCreatePropertyId,
declared in ChakraCore.h. So update the doc to match the source code.
    @xiaoyinl
    xiaoyinl committed Aug 22, 2017
    Configuration menu
    Copy the full SHA
    de86532 View commit details
    Browse the repository at this point in the history