Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable APIs using synthesized types to be used on net35 #415

Merged
merged 9 commits into from
Nov 1, 2021
Merged

Enable APIs using synthesized types to be used on net35 #415

merged 9 commits into from
Nov 1, 2021

Conversation

jnm2
Copy link
Contributor

@jnm2 jnm2 commented Sep 23, 2021

Fixes #394

@jnm2 jnm2 force-pushed the templates_on_net35 branch from 842a5f7 to ff64648 Compare September 23, 2021 17:42
@jnm2 jnm2 force-pushed the templates_on_net35 branch 2 times, most recently from 7170209 to 30a60e9 Compare September 25, 2021 20:15
AArnott
AArnott requested changes Sep 28, 2021
View reviewed changes
Copy link
Member

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this work. I have a couple comments for you to resolve first, but look forward to merging.

src/Microsoft.Windows.CsWin32/templates/PCSTR.cs Outdated Show resolved Hide resolved
test/Microsoft.Windows.CsWin32.Tests/GeneratorTests.cs Outdated Show resolved Hide resolved
test/Microsoft.Windows.CsWin32.Tests/GeneratorTests.cs Outdated Show resolved Hide resolved
test/Microsoft.Windows.CsWin32.Tests/GeneratorTests.cs Outdated Show resolved Hide resolved
test/Microsoft.Windows.CsWin32.Tests/GeneratorTests.cs Outdated Show resolved Hide resolved
@jnm2 jnm2 force-pushed the templates_on_net35 branch from 30a60e9 to 163a6a7 Compare October 9, 2021 16:08
@jnm2 jnm2 changed the title Enable APIs using PCSTR, PCWSTR, PWSTR, or BOOL to be used on net35 Enable APIs using synthesized types to be used on net35 Oct 9, 2021
@jnm2
Copy link
Contributor Author

jnm2 commented Oct 9, 2021

Given how fundamental the changes were from how I had set up the tests, I started over (thus the force push).

@jnm2 jnm2 force-pushed the templates_on_net35 branch from 163a6a7 to 3236f79 Compare October 9, 2021 16:41
@jnm2 jnm2 marked this pull request as draft October 9, 2021 16:52
@jnm2 jnm2 force-pushed the templates_on_net35 branch from 9496fa0 to 7c7fab1 Compare October 9, 2021 17:03
@jnm2 jnm2 force-pushed the templates_on_net35 branch from 7c7fab1 to 3718a34 Compare October 9, 2021 17:14
@jnm2 jnm2 force-pushed the templates_on_net35 branch from 3718a34 to 2165b7f Compare October 9, 2021 17:34
@jnm2 jnm2 marked this pull request as ready for review October 9, 2021 17:34
AArnott
AArnott requested changes Oct 26, 2021
View reviewed changes
Copy link
Member

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good. Thank you. Just one enhancement please.

test/Microsoft.Windows.CsWin32.Tests/GeneratorTests.cs Show resolved Hide resolved
AArnott
AArnott approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AArnott AArnott merged commit 93076e7 into microsoft:main Nov 1, 2021
@jnm2 jnm2 deleted the templates_on_net35 branch November 1, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell left review comments

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

APIs which require PWSTR or PCWSTR cause build failure on net35
3 participants
@jnm2 @AArnott @sharwell