Update pytest and transformers with fixes for pytest>= 8.0.0 #5164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
loadams
commented
Feb 20, 2024
loadams
changed the title
loadams
changed the title
loadams
commented
Mar 6, 2024
mrwyattii
approved these changes
Mar 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rraminen
pushed a commit
to ROCm/DeepSpeed
that referenced
this pull request
May 9, 2024
…ft#5164) The underlying issue preventing us from using pytest 8.0.1+ is in transformers. Here is a [PR that fixes the issue](huggingface/transformers#29154) that will need to be merged and then a new release of transformers before we can complete this PR. No impact to nv-nightly, run [here](https://github.com/microsoft/DeepSpeed/actions/runs/8575192380/job/23503659644) Currently errors on nv-inference from [the PR](https://github.com/microsoft/DeepSpeed/actions/runs/8575187611/job/23503647378), but the same tests are broken in [master](https://github.com/microsoft/DeepSpeed/actions/runs/8575185551/job/23503640238).
umchand
pushed a commit
to umchand/DeepSpeed
that referenced
this pull request
May 20, 2024
…ft#5164) The underlying issue preventing us from using pytest 8.0.1+ is in transformers. Here is a [PR that fixes the issue](huggingface/transformers#29154) that will need to be merged and then a new release of transformers before we can complete this PR. No impact to nv-nightly, run [here](https://github.com/microsoft/DeepSpeed/actions/runs/8575192380/job/23503659644) Currently errors on nv-inference from [the PR](https://github.com/microsoft/DeepSpeed/actions/runs/8575187611/job/23503647378), but the same tests are broken in [master](https://github.com/microsoft/DeepSpeed/actions/runs/8575185551/job/23503640238).
dbyoung18
pushed a commit
to dbyoung18/DeepSpeed
that referenced
this pull request
Jun 11, 2024
…ft#5164) The underlying issue preventing us from using pytest 8.0.1+ is in transformers. Here is a [PR that fixes the issue](huggingface/transformers#29154) that will need to be merged and then a new release of transformers before we can complete this PR. No impact to nv-nightly, run [here](https://github.com/microsoft/DeepSpeed/actions/runs/8575192380/job/23503659644) Currently errors on nv-inference from [the PR](https://github.com/microsoft/DeepSpeed/actions/runs/8575187611/job/23503647378), but the same tests are broken in [master](https://github.com/microsoft/DeepSpeed/actions/runs/8575185551/job/23503640238).
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying issue preventing us from using pytest 8.0.1+ is in transformers. Here is a PR that fixes the issue that will need to be merged and then a new release of transformers before we can complete this PR.
No impact to nv-nightly, run here
Currently errors on nv-inference from the PR, but the same tests are broken in master.