Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add distributed_port for deepspeed.initialize #5260

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Add distributed_port for deepspeed.initialize #5260

merged 4 commits into from
Apr 3, 2024

Conversation

LZHgrla
Copy link
Contributor

@LZHgrla LZHgrla commented Mar 12, 2024 •
edited
Loading

deepspeed.initialize does not involve the distributed_port argument, and always uses TORCH_DISTRIBUTED_DEFAULT_PORT to initialize the dist env

@LZHgrla LZHgrla requested a review from mrwyattii as a code owner March 12, 2024 10:49
@tjruwase tjruwase added this pull request to the merge queue Mar 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 26, 2024
@LZHgrla
Copy link
Contributor Author

LZHgrla commented Mar 27, 2024

@tjruwase Hi!
I merged the main branch into this PR. Waiting for the approval of the CI.

@LZHgrla
Copy link
Contributor Author

LZHgrla commented Apr 2, 2024

@tjruwase
Hi! Any update about this PR?

@tjruwase tjruwase added this pull request to the merge queue Apr 2, 2024
Merged via the queue into microsoft:master with commit dc3554f Apr 3, 2024
14 checks passed
rraminen pushed a commit to ROCm/DeepSpeed that referenced this pull request May 9, 2024
@LZHgrla @tjruwase
@loadams @rraminen
Add distributed_port for deepspeed.initialize (microsoft#5260)
a7698c4 
`deepspeed.initialize` does not involve the `distributed_port` argument,
and always uses `TORCH_DISTRIBUTED_DEFAULT_PORT` to initialize the dist
env

Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com>
Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
umchand pushed a commit to umchand/DeepSpeed that referenced this pull request May 20, 2024
@LZHgrla @tjruwase
@loadams @umchand
Add distributed_port for deepspeed.initialize (microsoft#5260)
a25f12c 
`deepspeed.initialize` does not involve the `distributed_port` argument,
and always uses `TORCH_DISTRIBUTED_DEFAULT_PORT` to initialize the dist
env

Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com>
Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
dbyoung18 pushed a commit to dbyoung18/DeepSpeed that referenced this pull request Jun 11, 2024
@LZHgrla @tjruwase
@loadams @dbyoung18
Add distributed_port for deepspeed.initialize (microsoft#5260)
a28fd12 
`deepspeed.initialize` does not involve the `distributed_port` argument,
and always uses `TORCH_DISTRIBUTED_DEFAULT_PORT` to initialize the dist
env

Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com>
Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjruwase tjruwase tjruwase approved these changes

@mrwyattii mrwyattii Awaiting requested review from mrwyattii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LZHgrla @tjruwase @loadams