-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle when backend
is also in compile_kwargs
#6502
Conversation
Hi @oraluben, Can you elaborate your goal with this PR? |
Sure! In the case where "backend" is also in compile_kwargs dict, the current version fails with an error that "backend" arg is provided twice. In this PR, I use the backend arg to override possible backend value in compile_kwargs. An example is huggingface/accelerate#3069, I have to pop backend before pass compile_kwargs to engine.compile |
Hi @oraluben, I agree with the fix, but the method for merging dictionaries is not correct, as the tests have failed. Could you address this? |
Is there anything wrong with the CI? My PRs keep timeout in v100. |
Yes this looks to be an issue on our side, I will take care of this. |
cc @tohtana