reduce setting global variables to reduce torch compile graph breaks #6541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting global variables when running will create a graph break when using torch.compile (reading globals is ok however). this commit attempts to reduce the setting of globals in the checkpointing flow. there are 2 main uses setting globals: 1. share data between functions 2. establish that this is the first call to the code for most of the cases the data in the globals is values that can be computed on demand or set once in an initial state in a configure funtion. for "check that this is the first run" use case the code was moved to the configure funciton.
tjruwase
approved these changes
Sep 20, 2024
…educe_compile_graph_breaks
…educe_compile_graph_breaks
…educe_compile_graph_breaks
…educe_compile_graph_breaks
…educe_compile_graph_breaks
…educe_compile_graph_breaks
auto-merge was automatically disabled
October 1, 2024 11:39
Head branch was pushed to by a user without write access
…educe_compile_graph_breaks
…educe_compile_graph_breaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting global variables during training will create a graph breaks when using torch.compile (reading global variables doesn't). this commit attempts to reduce the setting of global variables in the checkpointing flows.
there are 2 main uses setting global variables:
For most of the cases the data in the global variables is data that can be computed on demand or set once in an initial state in a configure function.
For "check that this is the first run" use case the code was moved to the configure function.