Increase CI coverage for Gaudi2 #6728
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadams
approved these changes
Nov 8, 2024
|
Tagging @raza-sikander for the failures on the newly added tests. Let us know if we need to modify anything on the node. |
loadams
changed the title
loadams
reviewed
Nov 11, 2024
| @@ -49,51 +49,64 @@ jobs: | |||
| TORCHINDUCTOR_COMPILE_THREADS: 1 | |||
| TEST_LIST: | | |||
| test_accelerator.py | |||
| test_activation_checkpointing.py | |||
There was a problem hiding this comment.
@raza-sikander - it looks like the tests pass now but take 2.5 hours to run. Should we switch some of the tests to a cron job if they take that long? Since triggering on as many PRs as this yml file does means we may see queueing there.
There was a problem hiding this comment.
Hi @loadams, We can split it as you mentioned.
Can you share the process for creation of cron job? So i can split the content two.
And also it would mean we would have two jobs one for CI and other like nightly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.