[spirv] Remove BufferBlock for array types #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build DirectXShaderCompiler 1.0.3434 completed (commit a677681280 by @jaebaek) |
|
Just tested, this fixes the issue for us. |
ehsannas
suggested changes
Jul 15, 2020
| @@ -33,6 +33,23 @@ bool RemoveBufferBlockVisitor::visit(SpirvModule *mod, Phase phase) { | |||
| return true; | |||
| } | |||
|
|
|||
| bool RemoveBufferBlockVisitor::HasStorageBufferInterfaceType( | |||
There was a problem hiding this comment.
s/HasStorageBufferInterfaceType/hasStorageBufferInterfaceType
| ptrResultType->getStorageClass() != | ||
| spv::StorageClass::StorageBuffer) { | ||
| if (ptrResultType->getStorageClass() != | ||
| spv::StorageClass::StorageBuffer) { |
There was a problem hiding this comment.
can now do
if (hasStorageBufferInterfaceType(ptrResultType->getPointeeType()) &&
ptrResultType->getStorageClass() != spv::StorageClass::StorageBuffer) {
...
}
jaebaek
commented
Jul 15, 2020
| @@ -33,6 +33,23 @@ bool RemoveBufferBlockVisitor::visit(SpirvModule *mod, Phase phase) { | |||
| return true; | |||
| } | |||
|
|
|||
| bool RemoveBufferBlockVisitor::HasStorageBufferInterfaceType( | |||
| ptrResultType->getStorageClass() != | ||
| spv::StorageClass::StorageBuffer) { | ||
| if (ptrResultType->getStorageClass() != | ||
| spv::StorageClass::StorageBuffer) { |
|
✅ Build DirectXShaderCompiler 1.0.3437 completed (commit cff50187cc by @jaebaek) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing BufferBlock and replacing Uniform to StorageBuffer
must be done for not only the struct type whose interface type
is StorageBuffer but also for an array or runtime array type whose
element type is such struct type.
Fixes #3035