Add -HV 2021 to test that uses templates
#5544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent fix (microsoft#5534) modified this test by removing the `-HV 2021` flag. That change was fine because flag is not needed now that 2021 is the default language version. However, we have a downstream consumer of this repo where we have not yet migrated to 2021 as the default language version. Rather than modifying the test in the downstream repo it was suggested that we add the flag back in the upstream repo to minimize churn.
bfavela
approved these changes
Aug 14, 2023
damyanp
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent fix (#5534) modified this test by removing the
-HV 2021flag. That change was fine because flag is not needed now that 2021 is the default language version.However, we have a downstream consumer of this repo where we have not yet migrated to 2021 as the default language version. Rather than modifying the test in the downstream repo it was suggested that we add the flag back in the upstream repo to minimize churn.