-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build for a Windows 8.1 minimum #517
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows 7 was 0x0601. Windows 8 was 0x0602. Both are well past their life-cycle. While Windows 8.1 is also out-of-support, it was only retired as of last year so I'm keeping it for now.
DirectXTK_Desktop_2019/2022.vcxproj now include DirectX Tool Kit for Audio targeting XAudio 2.8. There are no individual MSBuild projects under
Audio
. This is consistent with the original DirectXTK_Desktop_2019/2022.sln which included the now defunct DirectXTKAudio_Desktop_2019/2022_Win8.vcxproj.CMake
BUILD_XAUDIO_WIN7
build option renamedBUILD_XAUDIO_REDIST
to use the XAudio2Redist. CMake presets likex64-Debug-Win7
are nowx64-Debug-Redist
for XAudio2Redist.GamePad always uses XInput 1.4 rather than XInput 9.1.0
Always uses CreateFile2, GetOverlappedResultEx, and WIC2