Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python build with a far more portable wheel #396

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Python build with a far more portable wheel #396

merged 3 commits into from
Jul 20, 2023

Commits on Jul 20, 2023

  1. Identified the appropriate build flags to get a working python build … 

    …that doesn't rely on -march=native or -mtune=native. We've run benchmarks on multiple computers that indicate the only important flag other than -mavx2 -msse2 -mfma is -funroll-loops. Optimization levels such as -O1, -O2, or -O3 actually makes for less performant code. -Ofast is unavailble for use in Python, as it causes problems with floating point math in Python
    @daxpryce
    daxpryce committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    f9b410c View commit details
    Browse the repository at this point in the history

  2. 1.22 was left in a comment despite 1.25 being the value specified

    @daxpryce
    daxpryce committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    cd12906 View commit details
    Browse the repository at this point in the history

  3. Python 3.8 is not supported by numpy 1.25, so we're removing it.

    @daxpryce
    daxpryce committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    7aa7e51 View commit details
    Browse the repository at this point in the history