Add r3r4 templates #357
Add r3r4 templates #357
Conversation
sowu880
force-pushed
the
personal/sowu/add-R3R4-templates
branch
from
715bb1f to
35a5aef
Compare
… into personal/sowu/add-R3R4-templates
… into personal/sowu/add-R3R4-templates
… into personal/sowu/add-R3R4-templates
…/microsoft/FHIR-Converter into personal/sowu/add-R3R4-templates
| @@ -12,6 +12,7 @@ | |||
| }, | |||
| {% endif -%} | |||
| ], | |||
| "fhirVersion": "4.0.1", | |||
There was a problem hiding this comment.
Just curious~ Do we need to update it in other resources?
There was a problem hiding this comment.
For example, it may appear in ImplementationGuide:
There was a problem hiding this comment.
Might be. In this first round of update, I only modify the value of "fhirVersion" field with 'N' priority, and plan to update others for template refinement. (Since value change in Stu3 to R4 is nice to have.)
data/Templates/Stu3ToR4/DataType/DataRequirement/_CodeFiter.liquid
Outdated
Show resolved
Hide resolved
data/Templates/Stu3ToR4/DataType/_CodeableConcept2Attachment.liquid
Outdated
Show resolved
Hide resolved
|
Just curious~ Do we have any tests to check the quality of templates now? |
| @@ -1,7 +1,7 @@ | |||
| {% mergeDiff msg -%} | |||
| { | |||
| "targetProfile" : [ | |||
| {{msg.profile | to_json_string}} | |||
| {{msg.profile | to_json_string | default : '""'}} | |||
| ], | |||
| "profile" : "", | |||
| "binding" : {% include 'OperationDefinition/Binding' msg: msg.binding -%}, | |||
There was a problem hiding this comment.
The template name needs to be uppercase. OperationDefinition/parameter should be OperationDefinition/Parameter
| "type" : {% include 'DataType/CodingToCodeableConcept' msg: msg.type -%}, | ||
| "transform" : {% include 'DataType/ReferenceToCanonical' msg: msg.transform -%}, | ||
| "dynamicValue" : [ {{ msg.dynamicValue | to_array | batch_render: 'PlanDefinition/DynamicValue', 'msg' }} ], | ||
| "action" : [ {{ msg.action | to_array | batch_render: 'PlanDefinition/action', 'msg' }} ], |
There was a problem hiding this comment.
Same~ PlanDefinition/action should be PlanDefinition/Action
| "documentation" : [ {{ msg.documentation | to_array | batch_render: 'DataType/RelatedArtifact', 'msg' }} ], | ||
| "condition" : [ {{ msg.condition | to_array | batch_render: 'RequestGroup/Condition', 'msg' }} ], | ||
| "type" : {% include 'DataType/CodingToCodeableConcept' msg: msg.type -%}, | ||
| "action" : [ {{ msg.action | to_array | batch_render: 'RequestGroup/action', 'msg' }} ], |
There was a problem hiding this comment.
Same~ RequestGroup/action should be RequestGroup/Action
There was a problem hiding this comment.
Thanks! I checked all templates again to avoid lowercase. (I find that template name are case insensitive in local file system but sensitive in ACR templates. That's the reason why it not affect the result in my local tests.)
Case sensitive is not consistent in file system and ACR is a bug needs to fixed in the future. @qiwjin
I have tests to enable convert results are validate R4 resource locally for all templates. But for now, we only have tests for 'N' priority stu3 resources in convert's unit tests. We can add more in the future and design more tests to check quality. |
No description provided.