Fix filters in if tag #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanWanxx
requested review from
hongyh13,
qiwjin,
BoyaWu10,
sowu880 and
yankunhuang-pku
…ft/FHIR-Converter into personal/quwan/Fix_Filters_In_If
yankunhuang-pku
approved these changes
Apr 24, 2022
|
Could you help to double confirm these changes of C-CDA templates? @hongyh13 |
| {% include 'Resource/Condition' conditionEntry: entryRelationship.observation, ID: observationId -%} | ||
| {% assign fullObservationId = observationId | prepend: 'Condition/' -%} | ||
| {% include 'Reference/MedicationAdministration/ReasonReference' ID: substanceAdministrationId, REF: fullObservationId-%} | ||
| {% endif -%} | ||
|
|
||
| {% if entryRelationship.supply.templateId | to_json_string | contains '"2.16.840.1.113883.10.20.22.4.17"' -%} | ||
| {% assign templateIdString = entryRelationship.supply.templateId | to_json_string -%} |
There was a problem hiding this comment.
Need we double-check what happens when reassigning a new value to templateIdString?
There was a problem hiding this comment.
I checked the re-assignment case, the newest assign takes effect, which means the assign behavior align with our expects.
Templates:
{
...
{% assign templateIdString = r.observation.templateId | to_json_string -%}
"templateIdString1": "{{ templateIdString | escape_special_chars }}",
...
{% assign templateIdString = allergyEntry.entryRelationship | to_json_string -%}
"templateIdString2": "{{ templateIdString | escape_special_chars }}",
...
}
Result:
"templateIdString1": "{\"root\":\"2.16.840.1.113883.10.20.22.4.9\"}",
"templateIdString2": "[{\"typeCode\":\"SUBJ\",\"inversionInd\":\"true\",\"observation\":......"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the filters in liquid
iftag, filters are only supported on a subset of tags (e.g.assigntag), which don't includeif,fororcasetags. Refer to this issue in Shopify/liquid repo.E.g. The below condition will always true as long as
relationship.observation.templateIdis not null, the followed filter pipes| to_json_string | contains: '"2.16.840.1.113883.10.20.22.4.7"'takes no effetcs.