Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to NJsonSchema lib #415

Merged
merged 5 commits into from
Aug 5, 2022
Merged

Change to NJsonSchema lib #415

merged 5 commits into from
Aug 5, 2022

Conversation

QuanWanxx
Copy link
Contributor

Change the json schema lib to NJsonSchema to avoid the validate count limit.

@QuanWanxx QuanWanxx marked this pull request as ready for review July 29, 2022 07:54
@yankunhuang-pku
Copy link
Contributor

Is it possible to add some unit tests for this fix about the validate count limit?

@QuanWanxx
Copy link
Contributor Author

Is it possible to add some unit tests for this fix about the validate count limit?
Added, thanks for reminding.

@QuanWanxx QuanWanxx merged commit 2dcf005 into dotliquid Aug 5, 2022
@QuanWanxx QuanWanxx deleted the personal/quwan/Change-JsonSchema-Lib branch August 5, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yankunhuang-pku yankunhuang-pku yankunhuang-pku approved these changes

@moria97 moria97 Awaiting requested review from moria97

@sowu880 sowu880 Awaiting requested review from sowu880

@qiwjin qiwjin Awaiting requested review from qiwjin

@ACMoretxj ACMoretxj Awaiting requested review from ACMoretxj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuanWanxx @yankunhuang-pku @moria97