This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Security: Do not persists ADA Refesh Tokens #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whoisj
added
bug
Azure Directory Refresh Tokens are over-privileged for any use the GCM would need them for, therefore they should be discarded as soon as they're no longer needed. The only use of ADA refresh tokens is to use them to acquire VSTS personal access tokens - therefore they should only be persisted long enough to do so, then they should be discared. Additionally, since the GCM has been caching them in the Windows Credential Manager historically, the GCM should make efforts to removed the ADA tokens it has cached.
whoisj
force-pushed
the
no-persist-ada-tokens
branch
from
dd911c9
to
4673508
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure Directory Refresh Tokens are over-privileged for any use the GCM would need them for, therefore they should be discarded as soon as they're no longer needed.
The only use of ADA refresh tokens is to use them to acquire VSTS personal access tokens - therefore they should only be persisted long enough to do so, then they should be discared.
Additionally, since the GCM has been caching them in the Windows Credential Manager historically, the GCM should make efforts to removed the ADA tokens it has cached.
resolves #200