simplify

microsoft · May 17, 2020 · 0da6025 · 0da6025
1 parent fcd14c4
commit 0da6025
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/boosting/prediction_early_stop.cpp b/src/boosting/prediction_early_stop.cpp
@@ -74,18 +74,18 @@ PredictionEarlyStopInstance CreateBinary(const PredictionEarlyStopConfig& config
 
 PredictionEarlyStopInstance CreatePredictionEarlyStopInstance(const std::string& type,
                                                               const PredictionEarlyStopConfig& config) {
-  if (type != "none" && type != "multiclass" && type != "binary") {
-    Log::Fatal("Unknown early stopping type: %s", type.c_str());
-  }
-
   if (type == "none") {
     return CreateNone(config);
   } else if (type == "multiclass") {
     return CreateMulticlass(config);
+  } else if (type == "binary") {
+    return CreateBinary(config);
+  } else {
+    Log::Fatal("Unknown early stopping type: %s", type.c_str());
   }
 
-  // "binary"
-  return CreateBinary(config);
+  // Fix for compiler warnings about reaching end of control
+  return CreateNone(config);
 }
 
 }  // namespace LightGBM