fix

microsoft · Nov 26, 2019 · f50d6c4 · f50d6c4
1 parent a477564
commit f50d6c4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/R-package/R/lgb.Dataset.R b/R-package/R/lgb.Dataset.R
@@ -533,7 +533,9 @@ Dataset <- R6::R6Class(
 
     # Update parameters
     update_params = function(params) {
-      private$params <- modifyList(private$params, params)
+      if (lgb.is.null.handle(private$handle)) {
+        private$params <- modifyList(private$params, params)
+      }
       return(invisible(self))
 
     },

diff --git a/python-package/lightgbm/basic.py b/python-package/lightgbm/basic.py
@@ -1165,18 +1165,18 @@ def save_binary(self, filename):
         return self
 
     def _update_params(self, params):
-        if not self.params:
-            self.params = copy.deepcopy(params)
-        else:
-            self.params_back_up = copy.deepcopy(self.params)
-            self.params.update(params)
+        if self.handle is None:
+            if not self.params:
+                self.params = copy.deepcopy(params)
+            else:
+                self.params_back_up = copy.deepcopy(self.params)
+                self.params.update(params)
         return self
 
     def _reverse_update_params(self):
-        self.params = copy.deepcopy(self.params_back_up)
-        self.params_back_up = None
-        if self.handle is not None and self.params is not None:
-            _safe_call(_LIB.LGBM_DatasetUpdateParam(self.handle, c_str(param_dict_to_str(self.params))))
+        if self.handle is None:
+            self.params = copy.deepcopy(self.params_back_up)
+            self.params_back_up = None
         return self
 
     def set_field(self, field_name, data):